Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to distinguish Vulkan profiles by major and or minor Vulkan version #48

Open
SaschaWillems opened this issue Mar 28, 2023 · 2 comments

Comments

@SaschaWillems
Copy link
Collaborator

I've been getting several reports from users of my database that exported profile JSONs were missing properties. After doing some research, this seems to be caused by how I apply the appropriate JSON schema.

Right now I just select the the schema based on the header revision in it's filename. E.g. if a device has Vulkan 1.3.232 I select the profiles-0.8.1-232.json file as a basis for generating the profiles JSON.

But this becomes a problem if a device reports a revision that's not matching it's major/minor version. E.g. a device that has Vulkan 1.3.128 would match to filename profiles-0.8.1-118.json. But that profile file is for Vulkan 1.1 and not Vulkan 1.3.

Not sure how to handle this without doing some manual mapping.

So my question is: Would it be possible to adjust the profile files naming schema and not only include the header revision, but also the major and minor version.

So e.g. profiles-0.8.1-118.json would become profiles-0.8.1-1.1.118.json`. That would make things a lot easier for me on the database side.

@SaschaWillems
Copy link
Collaborator Author

@christophe-lunarg : Any idea on this? This kinda blocks me from updating the profiles for my database.

@christophe-lunarg
Copy link
Collaborator

Hi @SaschaWillems !

Something I don't understand is that we don't provide Vulkan 1.1 versin of the profiles so I am not sure what would do
profiles-0.8.1-118.json would become profiles-0.8.1-1.1.118.json

I am not also really understanding this sentence:

But this becomes a problem if a device reports a revision that's not matching it's major/minor version. E.g. a device that has Vulkan 1.3.128 would match to filename profiles-0.8.1-118.json. But that profile file is for Vulkan 1.1 and not Vulkan 1.3.

Because Vulkan 1.3 is a superset of Vulkan 1.1 so the profiles-0.8.1-118.json schema would validate a Vulkan 1.1 profile. Are you using the schema to figure out what to write in the profiles file? The schema cointains many extensions that most implementation don't support so I hardly imagine this approach...

Erm... well... no just I am any helpful here... :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants