Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor Popup search issues - any fixes? #76

Open
stjcrisp opened this issue Jul 17, 2024 · 2 comments
Open

Minor Popup search issues - any fixes? #76

stjcrisp opened this issue Jul 17, 2024 · 2 comments

Comments

@stjcrisp
Copy link

Really loving the theme so far, just a couple of small issues I've noticed with uc.tweak.popup-search. I'm wondering if anybody has come across the same and knows of a fix?

  • Attempting to right click the text inside of the popup search closes it immediately, so it makes copying/pasting with a mouse painful.
  • When opening the popup search from an existing webpage, the existing url is not highlighted and then requires a the user to manually highlight with their mouse or via ctrl-a. This is something other browsers do by default so it's a bit jarring to get used to.

Any insight would be much appreciated!

@beracira
Copy link
Contributor

These two all circle back to the logic behind the popup urlbar: the popup triggers when it's focused.

First one: it'd be a bit tricky to implement that because the moment you right click on the text, the urlbar is no longer in focus. I can dig around and see if we can work around that.

Second one: I've been using CTRL + L to invoke the popup, which automatically selects the existing URL.

@mattkel
Copy link

mattkel commented Nov 20, 2024

For the first one I just right click the urlbar input when it's not focused and when the popup isn't shown and it works as normal.

I also sometimes use Ctrl+L to invoke the urlbar, but I found a fix/workaround for the second one. I don't use this theme, instead I just added the code from the popout-search.css to my own userChrome.css. Anyways, changing position: fixed to position: absolute seemed to fix it. The only caveat now is the popout isn't centered horizontally, so I just manually centered it by changing the left value inside the #urlbar, you'll have to play around with it to see if it looks centered for you - there's probably a better way to do it but I just found this theme tonight and can't be bothered looking into it more atm. Here's the css I use, I deleted everything else in the popout-search.css because it wasn't necessary for my setup.
Edit: added the proper codeblock

#urlbar:is([breakout][breakout-extend], [breakout][usertyping][focused]) {
  #urlbar-input {
    font-size: 16px !important;
  }

  z-index: 1;
  /* position: fixed !important; --- original */
  position: absolute !important;
  top: 20vh !important;
  /* left: 18vw !important; --- original */
  left: -60px !important; /* --- change to whatever looks centered --- */
  width: 54vw !important;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants