Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other Calendar Types Implementation #12

Open
pkhodaveissi opened this issue Nov 6, 2018 · 2 comments
Open

Other Calendar Types Implementation #12

pkhodaveissi opened this issue Nov 6, 2018 · 2 comments

Comments

@pkhodaveissi
Copy link

Hi and thanks for this great repo

what's the best way to start making other types of calendars like Jalali using your tool?

here's a Jalali Moment Library:
https://www.npmjs.com/package/moment-jalaali

@wcastand
Copy link
Contributor

wcastand commented Nov 6, 2018

Hi, i don't know Jalali calendar so maybe i'm missing some specificity about it but from what i could see the "easiest" way would be to implement jalali with date-fns (the package we use for dates).

If date-fns supports jalali then okami should be able to use it and format it like any other date system.

You should probably go on date-fns github and make an issue to know if that's possible and how you can help maybe. (if you do an issue, please link it to that one so we can follow more easily and maybe help :))

An other solution would to fork this repo and replace date-fns with moment so you can add moment-jalali library.

@pkhodaveissi
Copy link
Author

This is the submitted issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants