Skip to content

Commit f1d3c6f

Browse files
authored
Merge pull request #156 from KingsburyLab/bugfix
Hotfix v1.1.5 - remove stray assert statement
2 parents 8c565ae + 65beb17 commit f1d3c6f

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
55
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
66
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
77

8+
## [1.1.5] - 2024-07-28
9+
10+
### Fixed
11+
12+
- `Solution`: Hotfix to remove a stray `assert` statement in `_adjust_charge_balance`
13+
that would sometimes cause errors in`pH` charge balancing.
14+
815
## [1.1.4] - 2024-07-28
916

1017
### Fixed

src/pyEQL/solution.py

-1
Original file line numberDiff line numberDiff line change
@@ -2316,7 +2316,6 @@ def _adjust_charge_balance(self, atol=1e-8) -> None:
23162316
)
23172317
self.set_amount("H+", f"{new_hplus} mol/L")
23182318
self.set_amount("OH-", f"{K_W/new_hplus} mol/L")
2319-
assert np.isclose(self.charge_balance, 0, atol=atol), f"{self.charge_balance}"
23202319
return
23212320

23222321
z = self.get_property(self._cb_species, "charge")

0 commit comments

Comments
 (0)