Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Other] Migrate away from antlr4ts to direct Antlr4 TypeScript target generation #518

Open
1 task done
Luna-Klatzer opened this issue May 17, 2024 · 1 comment
Open
1 task done
Assignees
Labels
breaking change This is a breaking change maintenance Maintenance related to keep the repo or code up-to-date and working
Milestone

Comments

@Luna-Klatzer
Copy link
Member

Is there an existing issue for this?

  • I have searched the existing issues

Current State & Issue

As described in tunnelvisionlabs/antlr4ts#549, the need of using antlr4ts to generate the language Lexer and Parser has vanished, as the base Antlr4 package now provides such functionality as well.

As such to avoid depending on a deprecated project which itself is also incompatible with newer versions, we will need to migrate away and adjust our lexer & parser generation workflows.

@Luna-Klatzer Luna-Klatzer added breaking change This is a breaking change maintenance Maintenance related to keep the repo or code up-to-date and working high priority High priority issue, discussion or pull request labels May 17, 2024
@Luna-Klatzer Luna-Klatzer self-assigned this May 17, 2024
@Luna-Klatzer Luna-Klatzer removed the high priority High priority issue, discussion or pull request label Jun 25, 2024
@Luna-Klatzer Luna-Klatzer added this to the v0.11.0 milestone Jun 25, 2024
@Luna-Klatzer
Copy link
Member Author

Luna-Klatzer commented Jun 25, 2024

As the current package antlr4ts is optimised and likely performs better, we might have to look into whether this migration is even viable, as migrating the parser/lexer generator is not essential for the package's security or similar.

@Luna-Klatzer Luna-Klatzer modified the milestones: v0.11.0, v0.12.0 Jul 9, 2024
@Luna-Klatzer Luna-Klatzer modified the milestones: v0.12.0, v0.13.0 Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change This is a breaking change maintenance Maintenance related to keep the repo or code up-to-date and working
Projects
Development

No branches or pull requests

1 participant