Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Hangar support #62

Open
Ghost-chu opened this issue Apr 23, 2023 · 7 comments
Open

[Feature Request] Hangar support #62

Ghost-chu opened this issue Apr 23, 2023 · 7 comments
Labels
enhancement New feature or request

Comments

@Ghost-chu
Copy link

Hanger: https://hangar.papermc.io/
API: https://hangar.papermc.io/api-docs

@Ghost-chu Ghost-chu changed the title Hanger support [Feature Request] Hanger support Apr 23, 2023
@Kir-Antipov Kir-Antipov changed the title [Feature Request] Hanger support [Feature Request] Hangar support May 20, 2023
@Kir-Antipov Kir-Antipov added the enhancement New feature or request label May 20, 2023
@Andre601
Copy link

For sake of info and transparency (I suppose) am I mentioning my discussion about hangar, which brings some current limitations that mc-publish can't bypass or find a neat workaround for without heavy rewrites (Based on the author's reply).

#65

Additionally, there is currently a Feature Request open that may help solve this issue if Hangar adds the required API paths for it... Link: HangarMC/Hangar#805

@HeatherComputer
Copy link

I don't suppose this has been considered since the old activity on this issue? I understand that a LOT about this workflow has changed since then.

@Kir-Antipov
Copy link
Owner

It has been and still is considered. Whenever Hangar has a functional API, I would be more than happy to implement support for it here.

@HeatherComputer
Copy link

Can I ask what's wrong with its current api?

@Andre601
Copy link

Can I ask what's wrong with its current api?

For once, you need to do 2 requests:

  • One request with your API Token to get a temporary token to use
  • A second request with said temp token to do actual stuff.

@Kir-Antipov
Copy link
Owner

Kir-Antipov commented Jun 18, 2024

For once, you need to do 2 requests

That's just annoying, but it's not really the problem.

Can I ask what's wrong with its current api?

You can refer to #65, where we discussed this with Andre601. Nothing has changed since then, except that after a whole year of "active development" there is somehow even less documentation than before.

To recap, Hangar's API is logically incompatible with mc-publish. Here, we publish a single mod/plugin/modpack/whatever to multiple platforms. There, they require you to publish multiple plugin versions to their platform in one go. While it's their project and they are free to succumb to whatever madness they prefer, their API is currently severely underdeveloped - they don't even have a PATCH route, so you either publish everything at once and just full send it, or you do not publish anything at all; there's nothing in between.

Until there is a way to publish different plugin versions separately (e.g., at least by PATCHing an existing combined Hangar "version"), there's nothing I can do. You may kindly ask the developers to implement such functionality or even contribute it yourself to accelerate the process, as it seems to be very stuck at the moment.

@HeatherComputer
Copy link

Ah, I see - after reading through #65, I do see why their post requests for version uploads don't suffice. It's a bit of a shame, but I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants