Skip to content

Commit d8ebf85

Browse files
committed
fix(platform): Remove unnecessary error toaster
1 parent c730e95 commit d8ebf85

File tree

2 files changed

+29
-55
lines changed
  • apps/platform/src/app/(main)/(project)/[workspace]/[project]

2 files changed

+29
-55
lines changed

apps/platform/src/app/(main)/(project)/[workspace]/[project]/@secret/page.tsx

+16-28
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import React, { useEffect, useMemo, useState } from 'react'
33
import { extend } from 'dayjs'
44
import relativeTime from 'dayjs/plugin/relativeTime'
55
import { useAtom, useAtomValue } from 'jotai'
6-
import { toast } from 'sonner'
76
import { Accordion } from '@/components/ui/accordion'
87
import ControllerInstance from '@/lib/controller-instance'
98
import SecretLoader from '@/components/dashboard/secret/secretLoader'
@@ -55,35 +54,24 @@ function SecretPage(): React.JSX.Element {
5554
)
5655

5756
useEffect(() => {
58-
const fetchSecrets = async () => {
59-
if (!selectedProject) {
60-
toast.error('No project selected', {
61-
description: (
62-
<p className="text-xs text-red-300">
63-
Please select a project to view secrets.
64-
</p>
65-
)
66-
})
67-
return
68-
}
69-
70-
try {
71-
setIsLoading(true)
72-
const { data, success } = await getAllSecretsOfProject()
73-
if (success && data) {
74-
setSecrets((prev) =>
75-
page === 0 ? data.items : [...prev, ...data.items]
76-
)
77-
if (data.metadata.links.next === null) {
78-
setHasMore(false)
57+
if (selectedProject) {
58+
setIsLoading(true)
59+
60+
getAllSecretsOfProject()
61+
.then(({ data, success }) => {
62+
if (success && data) {
63+
setSecrets((prev) =>
64+
page === 0 ? data.items : [...prev, ...data.items]
65+
)
66+
if (data.metadata.links.next === null) {
67+
setHasMore(false)
68+
}
7969
}
80-
}
81-
} finally {
82-
setIsLoading(false)
83-
}
70+
})
71+
.finally(() => {
72+
setIsLoading(false)
73+
})
8474
}
85-
86-
fetchSecrets()
8775
}, [getAllSecretsOfProject, isDecrypted, page, selectedProject, setSecrets])
8876

8977
const handleLoadMore = () => {

apps/platform/src/app/(main)/(project)/[workspace]/[project]/@variable/page.tsx

+13-27
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22

33
import { useEffect, useState } from 'react'
44
import { useAtom, useAtomValue } from 'jotai'
5-
import { toast } from 'sonner'
65
import {
76
selectedProjectAtom,
87
deleteVariableOpenAtom,
@@ -49,35 +48,22 @@ function VariablePage(): React.JSX.Element {
4948
)
5049

5150
useEffect(() => {
52-
const fetchVariables = async () => {
53-
if (!selectedProject) {
54-
toast.error('No project selected', {
55-
description: (
56-
<p className="text-xs text-red-300">
57-
Please select a project to view variables.
58-
</p>
59-
)
60-
})
61-
return
62-
}
51+
if (selectedProject) {
52+
setIsLoading(true)
6353

64-
try {
65-
setIsLoading(true)
66-
const { data, success } = await getAllVariablesOfProject()
67-
if (success && data) {
68-
setVariables((prev) =>
69-
page === 0 ? data.items : [...prev, ...data.items]
70-
)
71-
if (data.metadata.links.next === null) {
72-
setHasMore(false)
54+
getAllVariablesOfProject()
55+
.then(({ data, success }) => {
56+
if (success && data) {
57+
setVariables((prev) =>
58+
page === 0 ? data.items : [...prev, ...data.items]
59+
)
60+
if (data.metadata.links.next === null) {
61+
setHasMore(false)
62+
}
7363
}
74-
}
75-
} finally {
76-
setIsLoading(false)
77-
}
64+
})
65+
.finally(() => setIsLoading(false))
7866
}
79-
80-
fetchVariables()
8167
}, [getAllVariablesOfProject, page, selectedProject, setVariables])
8268

8369
const handleLoadMore = () => {

0 commit comments

Comments
 (0)