Update to use SecKeyCreateRandomKey to generate key pairs #36
Conversation
SecKeyGeneratePair was deprecated with iOS 15 Upgraded to support building with Xcode 14 - with no warnings Updated minimum supported versions - * MacOS - 11.5 * iOS - 14.5 * TVOS - 14.5 * WatchOS - 7.5 Added in a project file to make any future modifications easy build & test with Xcode
# Conflicts: # BlueECC.podspec
|
@dannys42 - Updated to just be the relevant changes - to continue to just dynamically generate the xcodeproject |
Add Xcode 14.2 support
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kris Kline seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
@dannys42 - If you happen to be picking these projects back up... This is another that I would love to have get merged in and released! 😄 |
| let pubKey = SecKeyCopyPublicKey(privKey) else { | ||
| throw ECError.failedNativeKeyCreation |
There was a problem hiding this comment.
Should this follow the pattern below of error.takeRetainedValue() ... throw error?
There was a problem hiding this comment.
That's fair...makes sense to be consistent in the error handling, will make the adjustment and update.
|
@LowAmmo Thanks for being patient and persistent. :-) |
|
SecKeyGeneratePair was deprecated with iOS 15
Upgraded to support building with Xcode 14 - with no warnings
Updated minimum supported versions -
Added in a project file to make any future modifications easy build & test with Xcode
Description
Motivation and Context
Issue: #35
Just addresses a build warning - so consumers can attempt to target a goal of 0 build warnings
How Has This Been Tested?
Via unit testing, and passivity testing our application.
Checklist:
(filled out an online form as part of submitting the PR on the BlueRSA repo)
(didn't see any places that needed to change)