Support for secure connection wss://

[bridger]

Kitura-NIO has a "todo" to support the wss upgrade. Does this mean secure websocket connections are not yet supported in this version of Kitura-Websocket?

[pushkarnk]

Presuming that a Kitura server, on which a WebSocket upgrade is requested for, has a configured SSLContext, we need to make sure that the subsequently configured NIOSSLServerHandler, which is the first InboundHandler and the last OutboundHandler is retained in the same position after a successful WebSocket upgrade. But I wonder how we are going to differentiate between a ws request and a wss request that are received on an HTTP server configured with SSL/TLS. Possibly here.

[pushkarnk]

OK, I figured out that we DO support WSS.

I set up a simple WebSocket echo service with a Kitura server like this:

let sslConfig: SSLConfig = {
    let sslConfigDir = URL(fileURLWithPath: #file).deletingLastPathComponent().appendingPathComponent("../SSLConfig")
    let chainFilePath = sslConfigDir.appendingPathComponent("certificateChain.pfx").standardized.path
    return SSLConfig(withChainFilePath: chainFilePath, withPassword: "kitura",
                     usingSelfSignedCerts: true)
}()

// Using an implementation for a Logger
HeliumLogger.use(.info)
let router = Router()
WebSocket.register(service: EchoService(), onPath: "/")
let port = 9001
Kitura.addHTTPServer(onPort: port, with: router, withSSL: sslConfig)
Kitura.run()

I then accessed the HTTPS URL: https://localhost:9001/ and added the certificate as prompted by the browser. After that I was able to make a wss connection to this echo service using the Simple WebSocket Client extension on Firefox/Chrome.

[pushkarnk]

I have changed all our client-server tests to use secure web socket connections: #19

[bridger]

Thank you for checking that it is supported!

[bridger]

Maybe the TODO should be removed from the code?