Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file-magic isn't listed in requirements.txt #307

Open
fishcorn opened this issue Mar 28, 2017 · 2 comments
Open

file-magic isn't listed in requirements.txt #307

fishcorn opened this issue Mar 28, 2017 · 2 comments

Comments

@fishcorn
Copy link
Contributor

fishcorn commented Mar 28, 2017

file-magic is a dependency in setup.py, but the Docker builds don't use that method.

Because the Docker image doesn't include it, when an image import is attempted with the caffe plugin, it fails to detect the file type and skips all inputs (producing many debug log outputs).

EDITED to add: There's barely any (if at all) indication that file-magic is what's needed. This can be frustrating to the uninitiated user.

@danlamanna
Copy link
Member

Related: #297

@Purg
Copy link
Member

Purg commented Nov 17, 2017

The file-magic module is no longer used in implicit functionality and is no longer a dependency in smqtk's setup.py. This to some degree resolves the title of this issue but does not resolve the usability issue that you mentioned (I think). The underlying issue is of lacking the right documentation for certain applications/utilities.

It is now the case that applications need to handle checking the presence of, or assigning loaded data a mimetype appropriately. When loaded data is a local file, whether that means making sure files have extensions or optionally running known filepaths through one of the smqtk.utils.file_utils module's inspection methods:
file_mimetype_filemagic or file_mimetype_tika.

Personally, I don't think that I consider a descriptor-generator raising an error a bad thing when given mimetype-less data elements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants