-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option for display RGB images as independent components #367
Comments
@oeway one possible approach is to set the
The behavior can be more similar to dependent components by setting the piecewise function to be flat as opposed to the default that is low at low intensities and increases to 1 at the highest intensity via: |
Great! I will try that! |
OK, just tried with pixelType=14 but got an error from DownsampleWasm.js:9 : |
Hmm, since It is likely that we can not getting |
Ah, we are missing |
I tried to debug it but gave up after some attempts. How do you usually debug this type of issue? Especially when we have both js and wasm. |
For Kaibu I found that:
worked. For WASM, Chrome recently added really cool WASM / C++ / DWARF support: https://developers.google.com/web/updates/2020/12/webassembly But I have not tried it, yet. |
Ok, thank you! I used npm link too, but I only did npm run build, without :debug. When I add debugger instructions, the code show up in the chrome debugger is not the actual source code, I guess with the :debug I will get the source map in the chrome debugger? BTW, for Kaibu, I hade some issue with importing itk vtk viewer, right now I am using a script tag without webpack compilation. Do you have any pointer for that? |
With :debug, it does not do minification in the build, which makes the code much more readable. What are the issues occurring during import? With the recent major refactor, we upgraded to Webpack 5, but that required a few Webpack workarounds. Patch to address the UNKNOWNPIXELTYPE issue: |
I tried a while ago, will test it later and report in another issue. Awesome! I am glad that you found the issue! |
Patch: #374 |
@thewtex Would you have a chance to look at the remaining issue with this thread? Basically when I use pixelType=14 I couldn't get it work with either RGB or RGBA image, it becomes gray. See here: imjoy-team/kaibu#50 |
@oeway yes will take a look 👍 |
Addressed in #382 . The hue of the result is now correct, although the image overall is darker -- will have to look into that. |
Cool! Thank you! |
#488 should address this. |
BTW, we now have good documentation for this: https://wasm.itk.org/examples/debugging.html#Chromium-based-browsers |
In some cases, we would like to adjust each color channel independently, so it would be nice to provide an option to make the contrast of each channel adjustable.
I did a quick test by forcing
actorContext.independentComponents=true
for RGB images, it show up as 3 channels, however, the overall intensity is much lower than normal.The text was updated successfully, but these errors were encountered: