Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not validate configuration at compile time #3

Open
nreynis opened this issue Nov 25, 2019 · 0 comments
Open

Do not validate configuration at compile time #3

nreynis opened this issue Nov 25, 2019 · 0 comments

Comments

@nreynis
Copy link

nreynis commented Nov 25, 2019

Some configuration like provider_base_url, client_secret and client_id are validated when the container is compiled:
https://github.com/KleeGroup/FranceConnect-Symfony/blob/master/DependencyInjection/Configuration.php#L45

It is not possible to use environment variables for thoses because of that. This validation should be done at runtime:

symfony/symfony#20684 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nreynis