Merge pull request #286 from KnapsackPro/fix-bug-rspec-in-base-class

Fix handling signals for non-RSpec test runners
KnapsackPro · Dec 4, 2024 · bc57ddd · bc57ddd
2 parents 9dd338a + 5236858
commit bc57ddd
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,13 @@
 # Changelog
 
+### 7.13.1
+
+* Fix handling signals for non-RSpec test runners
+
+    https://github.com/KnapsackPro/knapsack_pro-ruby/pull/286
+
+https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v7.13.0...v7.13.1
+
 ### 7.13.0
 
 * Add `KNAPSACK_PRO_FALLBACK_MODE_ERROR_EXIT_CODE` to specify a custom exit code whenever Knapsack Pro fails because Fallback Mode cannot be used

diff --git a/lib/knapsack_pro/runners/queue/base_runner.rb b/lib/knapsack_pro/runners/queue/base_runner.rb
@@ -59,12 +59,15 @@ def trap_signals
             Signal.trap(signal) {
               puts "#{signal} signal has been received. Terminating Knapsack Pro..."
               @@terminate_process = true
-              RSpec.world.wants_to_quit = true
+              post_trap_signals
               log_threads
             }
           end
         end
 
+        def post_trap_signals
+        end
+
         def log_threads
           threads = Thread.list
 

diff --git a/lib/knapsack_pro/runners/queue/rspec_runner.rb b/lib/knapsack_pro/runners/queue/rspec_runner.rb
@@ -117,6 +117,10 @@ def log_fail_fast_limit_met
 
         private
 
+        def post_trap_signals
+          RSpec.world.wants_to_quit = true
+        end
+
         def pre_run_setup
           ENV['KNAPSACK_PRO_QUEUE_RECORDING_ENABLED'] = 'true'
           ENV['KNAPSACK_PRO_QUEUE_ID'] = KnapsackPro::Config::EnvGenerator.set_queue_id