Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options inconsistency #171

Open
Koc opened this issue Sep 10, 2014 · 2 comments
Open

Options inconsistency #171

Koc opened this issue Sep 10, 2014 · 2 comments

Comments

@Koc
Copy link

Koc commented Sep 10, 2014

https://github.com/KnpLabs/KnpMenu/blob/master/doc/01-Basic-Menus.markdown#other-rendering-options Why some options is camelCased but other underscored?

@stof
Copy link
Collaborator

stof commented Sep 10, 2014

legacy. I would like to switch everything to underscores, but I'm not sure whether it is possible to provide a full BC layer, which is why I haven't done it everywhere

@shakaran
Copy link
Contributor

shakaran commented Aug 31, 2021

Update link to documentation is https://github.com/KnpLabs/KnpMenu/blob/master/doc/01-Basic-Menus.md#other-rendering-options

Options affected are:

I will make a separate pull request for each option updated. For avoid conflicts with master and each PR. It requires that will be accepted and merged to master one by one or I make a full PR with all the changes. I would prefer one by one, since it is more easy to follow the changes for maintainers. So waiting the approval of each merge one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants