Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpspec doesn't support php 8.4 #105

Open
tacman opened this issue Dec 9, 2024 · 2 comments
Open

phpspec doesn't support php 8.4 #105

tacman opened this issue Dec 9, 2024 · 2 comments

Comments

@tacman
Copy link
Contributor

tacman commented Dec 9, 2024

phpspec/phpspec": "^6.0 || ^7.0",

but phpspec doesn't support 8.4

There are some alternatives that do support php 8.4, like php-unit, but that's a pretty big rewrite of the tests.

I'm happy to do a PR to add phpstan,it's a great first step (and indeed caught the issue fixed in #104 )

@robbieaverill
Copy link
Collaborator

Hey @tacman, thank you for looking into this. I would be happy to wait for PHPSpec to support 8.4 (see phpspec/phpspec#1477). I don't think there's a big appetite for rewriting the whole test suite with another tool. What do you think?

If you wanted to add PHPStan I think that would be great, as a supplementary tool.

@robbieaverill
Copy link
Collaborator

Note to add 8.4 to the CI matrix when phpspec is upgraded to support it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants