Merge pull request #478 from KnpLabs/v2-unstable-change-interfaces

fix: Change interfaces function names
KnpLabs · Jun 23, 2023 · 857cad1 · 857cad1
2 parents f0c3a85 + efc2878
commit 857cad1
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 13 deletions.
diff --git a/src/Core/Bridge/FromFileToStringToPdf.php b/src/Core/Bridge/FromFileToStringToPdf.php
@@ -7,17 +7,16 @@
 use KnpLabs\Snappy\Core\FileToPdf;
 use KnpLabs\Snappy\Core\StringToPdf;
 use Psr\Http\Message\StreamInterface;
-use SplFileInfo;
 
 final class FromFileToStringToPdf implements FileToPdf
 {
     public function __construct(private StringToPdf $stringToPdf)
     {
     }
 
-    public function generate(SplFileInfo $file, ArrayAccess|array $options = []): StreamInterface
+    public function generateFromFile(\SplFileInfo $file, \ArrayAccess|array $options = []): StreamInterface
     {
-        return $this->stringToPdf->generate(
+        return $this->stringToPdf->generateFromString(
             file_get_contents($file->getPathname()),
             $options,
         );

diff --git a/src/Core/Bridge/FromStringToFileToPdf.php b/src/Core/Bridge/FromStringToFileToPdf.php
@@ -7,24 +7,23 @@
 use KnpLabs\Snappy\Core\FileToPdf;
 use KnpLabs\Snappy\Core\StringToPdf;
 use Psr\Http\Message\StreamInterface;
-use SplFileInfo;
 
 final class FromStringToFileToPdf implements StringToPdf
 {
     public function __construct(private FileToPdf $fileToPdf)
     {
     }
 
-    public function generate(string $html, ArrayAccess|array $options = []): StreamInterface
+    public function generateFromString(string $html, \ArrayAccess|array $options = []): StreamInterface
     {
         $path = tempnam(sys_get_temp_dir(), 'snappy_');
 
         try {
             file_put_contents($path, $html);
 
-            $file = new SplFileInfo($path);
+            $file = new \SplFileInfo($path);
 
-            $stream = $this->fileToPdf->generate($file, $options);
+            $stream = $this->fileToPdf->generateFromFile($file, $options);
         } finally {
             unlink($path);
         }

diff --git a/src/Core/FileToPdf.php b/src/Core/FileToPdf.php
@@ -2,11 +2,9 @@
 
 namespace KnpLabs\Snappy\Core;
 
-use ArrayAccess;
 use Psr\Http\Message\StreamInterface;
-use SplFileInfo;
 
 interface FileToPdf
 {
-    public function generate(SplFileInfo $file, ArrayAccess|array $options = []): StreamInterface;
+    public function generateFromFile(\SplFileInfo $file, \ArrayAccess|array $options = []): StreamInterface;
 }
diff --git a/src/Core/StringToPdf.php b/src/Core/StringToPdf.php
@@ -2,11 +2,9 @@
 
 namespace KnpLabs\Snappy\Core;
 
-use ArrayAccess;
 use Psr\Http\Message\StreamInterface;
-use SplFileInfo;
 
 interface StringToPdf
 {
-    public function generate(string $html, ArrayAccess|array $options = []): StreamInterface;
+    public function generateFromString(string $html, \ArrayAccess|array $options = []): StreamInterface;
 }
diff --git a/src/Core/UriToPdf.php b/src/Core/UriToPdf.php
@@ -0,0 +1,11 @@
+<?php
+
+namespace KnpLabs\Snappy\Core;
+
+use Psr\Http\Message\StreamInterface;
+use Psr\Http\Message\UriInterface;
+
+interface UriToPdf
+{
+    public function generateFromUri(UriInterface $url, \ArrayAccess|array $options = []): StreamInterface;
+}