-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imhotep creation devices converter misses exposes.climate().withSystemMode #8577
Comments
Hi @AntoineBarj, after reviewing the implementation, it turns out to be even simpler than initially thought. We only need to use climate.withSystemMode(['off', 'heat']) directly, without requiring the enum previously defined in our converter. |
Thank you for you feedback. Another topic is (maybe needs another issue): Is there a way to have the full system modes exposed, as for the mobile app ? I asked several time here and there, tried things by my own, but I never could access to the modes (auto/confort/eco/.../ off). Thank you |
Yes, I’m currently working with Imhotep creation :). Regarding your questions: The heater mode (auto, comfort, eco, etc.) is not currently exposed. |
I updated the Z2m integration, with the last fix, that includes the PR #8625 . sadly, it is 100% broken now. from HomeAssistant: 1- Changing the system mode heat-off has no impact on the thermostat/heater. It worked before and finnaly, as before, the thermostat cards in HA are basically not connected to the thermostat:
And now : i can not even modify the temperature setpoint, and all the associated automations, that previously worked are currently broken. below some logs from the thermostat:
@nicolasaxenco Can you please, as a hot fix revert back the PR #8625 ? |
Update : after deconnecting and painting a thermostat again, it seems to work better. We should ignore the previous comment . But the original issue is not fixed :(. 1:1 same behaviour @nicolasaxenco : I would need furthermore to contact you directly . Sorry for the disturbance, but I noticed an additional issue that does not belong to this issue: |
Sorry for the delay, I didn’t receive the notification. |
Disclaimer
(I originally posted a simialar issue here: Koenkk/zigbee2mqtt#25565, but I realized that this was not the right repo for this issue)
What happened?
The device PH25 from Imhotep creation is well recognized by z2mqtt, but its integration is only partial.
The current exposes for the heater mode are (according to https://www.zigbee2mqtt.io/devices/E-Ctrl.html):
But , when creating a climate card, all the default systemMode are available (not only "off" and "heat"), and switching between modes from the climate card has no effect on the actual systemMode:
When displaying the mqtt device properties, we can see this:
![image](https://private-user-images.githubusercontent.com/126399350/400205245-94a93a6f-b907-4af7-bd83-868e08a32495.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NTc4MDAsIm5iZiI6MTczOTY1NzUwMCwicGF0aCI6Ii8xMjYzOTkzNTAvNDAwMjA1MjQ1LTk0YTkzYTZmLWI5MDctNGFmNy1iZDgzLTg2OGUwOGEzMjQ5NS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjE1JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxNVQyMjExNDBaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zYzQ5MDkzMzdlODY0NDIyYzk0MzJjYTczMmY5YjlhZjhjNzIxNzQ3ZjM1Mjc3MmRjZDlhNGUyMmY2NTYxYzcxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.nefQZkmDlqty92SwXlXS6EBLxaXs2WkQPJO2xVj6rDc)
as you can see, there are two "SytemMode", and the climate.sytemMode is not linked to the exposed system mode.
What did you expect to happen?
The climate.systemMode should be 1:1 likend to the system mode that is exposed.
I think that there is a missing lines in the src/devices/imhotepcreation.ts.
I have no experience in such converters, but from what i guessed from other converters, i think we should add .withSystemMode(['off', 'heat']).
example below for the PH25 device
Am I right ? Is the author @nicolasaxenco of the PR https://github.com/Koenkk/zigbee2mqtt.io/pull/6478 in charge of the change ?
The text was updated successfully, but these errors were encountered: