fix: Fix log directories not being deleted (#25282)

lib/util/logger.ts

@@ -103,6 +103,7 @@ class Logger {
 
             this.fileTransport = new winston.transports.File(transportFileOptions);
             this.logger.add(this.fileTransport);
+            this.cleanup();
         }
 
         /* istanbul ignore next */
@@ -219,7 +220,7 @@ class Logger {
     }
 
     // Cleanup any old log directory.
-    public cleanup(): void {
+    private cleanup(): void {
         if (settings.get().advanced.log_directory.includes('%TIMESTAMP%')) {
             const rootDirectory = path.join(this.directory, '..');
 

test/logger.test.ts

@@ -49,23 +49,27 @@ describe('Logger', () => {
             rimrafSync(path.join(dir.name, d));
         }
 
-        for (let i = 0; i < 21; i++) {
+        for (let i = 0; i < 20; i++) {
             fs.mkdirSync(path.join(dir.name, `log_${i}`));
         }
 
-        expect(fs.readdirSync(dir.name).length).toBe(21);
-        logger.cleanup();
+        expect(fs.readdirSync(dir.name).length).toBe(20);
+        logger.init();
         expect(fs.readdirSync(dir.name).length).toBe(10);
     });
 
     it('Should not cleanup when there is no timestamp set', () => {
-        for (let i = 30; i < 40; i++) {
+        for (const d of fs.readdirSync(dir.name)) {
+            rimrafSync(path.join(dir.name, d));
+        }
+
+        for (let i = 30; i < 50; i++) {
             fs.mkdirSync(path.join(dir.name, `log_${i}`));
         }
 
         settings.set(['advanced', 'log_directory'], dir.name + '/bla');
-        expect(fs.readdirSync(dir.name).length).toBe(21);
-        logger.cleanup();
+        expect(fs.readdirSync(dir.name).length).toBe(20);
+        logger.init();
         expect(fs.readdirSync(dir.name).length).toBe(21);
     });