Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Replace uint16 role with uint256 badgeId #11

Open
1 task done
fabianschu opened this issue Jun 26, 2022 · 0 comments · Fixed by #12
Open
1 task done

Chore: Replace uint16 role with uint256 badgeId #11

fabianschu opened this issue Jun 26, 2022 · 0 comments · Fixed by #12

Comments

@fabianschu
Copy link
Collaborator

fabianschu commented Jun 26, 2022

Status Quo

  • some functions take a uint16 role while others have been update to use the badger-related uint256 badeId parameter that points to a tokenId on a ERC1155 contract
  • the latter should apply to all functions

Acceptance Criteria

  • the badgeId is used throughout the contract
@fabianschu fabianschu linked a pull request Jun 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant