Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only update eth-sdk when fetching new contracts #146

Open
dkent600 opened this issue Sep 14, 2022 · 0 comments
Open

Only update eth-sdk when fetching new contracts #146

dkent600 opened this issue Sep 14, 2022 · 0 comments
Assignees
@vipergtsrz

Comments

@dkent600
Copy link
Contributor

dkent600 commented Sep 14, 2022 •
edited
Loading

  1. We only need those ABIs when we are updating contract models, and only need do that when we are updating the ABIs we're using (see fetchContracts)

  2. we can save the extra time spent in postInstall

  3. we should not be requiring that npx be installed on the user's computer to be able to run npm ci
@dkent600 dkent600 changed the title Only update eth-sdk when fetching contracts Only update eth-sdk when fetching new contracts Sep 14, 2022
@vipergtsrz vipergtsrz self-assigned this Sep 14, 2022
vipergtsrz added a commit that referenced this issue Sep 14, 2022
@vipergtsrz
Remove the eth-sdk post install #146
1c9d49f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vipergtsrz vipergtsrz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkent600 @vipergtsrz