Doesn't respond or function on Edit 9.3.2

[glennhefley]

Does Not appear to work any longer as of Komodo Edit, version 9.3.2, build 16460, platform win32-x86. Will not search, and can't change the context (current file, opened files, active project) I'll download the source and try to compile it with this and see what happens.

[th3coop]

Any luck @glennhefley ? can we be of any assistance?

[cmb69]

Albeit having no previous experience developing Komodo extensions, I tried to give this a shot. The first problem I found is that the komodo-ui-loaded event doesn't seem to be triggered. Listening to the load event seems to work.

The next problem is that the ko.findresults API has obviously been changed for KomodoEdit 9. Formerly, ko.findresults.create() returned a manager object, but now it seems to rely on a callback. That breaks TodoSearcher.prototype.GetAndClearTheTodoTab (at least).

I'm already lost there, so any hints would be appreciated.

[glennhefley]

I'm sorry for not getting back sooner. I concure on what cmb69 found, but have no clue after that, and didn't know what to look for until cmb pointed it out o.O -- so, yeah, I'm a lot of help here.

[Naatan]

The next problem is that the ko.findresults API has obviously been changed for KomodoEdit 9. Formerly, ko.findresults.create() returned a manager object, but now it seems to rely on a callback. That breaks TodoSearcher.prototype.GetAndClearTheTodoTab (at least).

Can you link the the portion of code that you are looking to fix?

[cmb69]

Can you link the the portion of code that you are looking to fix?

At least https://github.com/Komodo/Todo/blob/master/content/todo-ko7.js#L315-L317 would have to be fixed. ko.findresults.managers[id]can most likely be replaced by ko.findresults.getManager(id), but I don't know how to replace ko.findresults.create(id).

[Naatan]

Thanks, that helps.

The issue is that findresults.create() has been changed to now be asynchronous. See: Komodo/KomodoEdit@5042536#diff-56e5180917856b95fc884fc3c9b9fdcfR95

So the code would simply have to be updated to support a callback parameter instead of getting the manager object from the return value.

[cmb69]

Thanks, Naatan, and sorry for the delay. I've now managed to make the Todo extension working with current Komodo Edit 9.3nightly, but it's somewhat of a hack, and Komodo 8 and older won't be supported. I hope to find some time to improve this.