-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login Dialog #19
Comments
Looks good. To reduce the 2 "Forgot username" and "Forgot password" buttons to one, maybe the login process could be rewritten to take the e-mail or the username instead of just the username, then the "Forgot username" button could be dropped entirely. And I think we should decide on one style for the text inputs. |
I think it's fine to keep the text styles mostly as they are, because it's more consistent with the rest of the application, so Login / Enter fields can remain the same, but I do like the "x" instead of "cancel" button, and I agree a single option for "Forgot password?" is more usual than having 2 separate functions for Forgot username / password. I would not add a logo in this modal, because it's rather packed already and then we also need a different logo for Semantic Kompakkt, so keeping it simple would be better. |
@Grizzly127 - great, this looks very simple and clean - I agree the input box you designed originally looks better, but it's a matter of how easy it would be to change it everywhere in one go. Maybe we can discuss with @ZetOE & @HeyItsBATMAN |
Following up on my previous comment, I think we should go ahead with this latest design shown in @Grizzly127's comment above. I think we can leave the input box redesign until next year, since we'll be changing quite a lot in the visual design then in any case. I would put this issue on the priority list, as it connects to the updates in the nav bar. @HeyItsBATMAN |
@lozanaross this does not yet address the case for when a user forgets their username (which can happen). What do you think of removing the username for login altogether, just keeping the combination of mail & password for logging in? This would involve some cleanup on the server, which is good in my opinion, and would get rid of the current "forgot username" and "forgot password" situation. The other option would be to allow logging in using either username or mail, but this would involve a bunch of "is the user logging in with username or with mail"-detection and handling. This is possible, but more likely to introduce bugs. The suggested design of @Grizzly127 would, other than swapping username with mail, stay the same. |
@HeyItsBATMAN From user perspective this would be best:
But if the risk of bugs is quite high, perhaps we can indeed stick to email only for now. Happy to go ahead with this and keep the design from @Grizzly127 and just using "Enter your email" instead of "username" as you suggest. |
Would totally agree on just using mail for logging in, as we also fixed some problems with that, mail is just more simple. Nice Design work :) |
What?
Suggestion for a new Login Dialog.
Logo on top
No cancel button, but a X to close the window
other placement for Register and Helpbuttons.
before:
after:
@HeyItsBATMAN @ZetOE @lozanaross
The text was updated successfully, but these errors were encountered: