Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login Dialog #19

Open
3 tasks
Grizzly127 opened this issue Jul 5, 2023 · 8 comments
Open
3 tasks

Login Dialog #19

Grizzly127 opened this issue Jul 5, 2023 · 8 comments
Assignees

Comments

@Grizzly127
Copy link
Contributor

What?

Suggestion for a new Login Dialog.
Logo on top
No cancel button, but a X to close the window
other placement for Register and Helpbuttons.

  • Decide if we want to use lines or input boxes
  • Two buttons for "Forgot username/password?" or only one? -> need to rewrite the login process
  • Option to make the password visible possible?

before:
Bildschirmfoto 2023-07-05 um 16 52 35

after:
Bildschirmfoto 2023-07-05 um 16 50 31

@HeyItsBATMAN @ZetOE @lozanaross

@HeyItsBATMAN
Copy link
Collaborator

Looks good. To reduce the 2 "Forgot username" and "Forgot password" buttons to one, maybe the login process could be rewritten to take the e-mail or the username instead of just the username, then the "Forgot username" button could be dropped entirely.

And I think we should decide on one style for the text inputs.

@lozanaross
Copy link

I think it's fine to keep the text styles mostly as they are, because it's more consistent with the rest of the application, so Login / Enter fields can remain the same, but I do like the "x" instead of "cancel" button, and I agree a single option for "Forgot password?" is more usual than having 2 separate functions for Forgot username / password.

I would not add a logo in this modal, because it's rather packed already and then we also need a different logo for Semantic Kompakkt, so keeping it simple would be better.

@Grizzly127
Copy link
Contributor Author

Thank you for your feedback. This is the new Login-dialog:

Bildschirmfoto 2023-07-25 um 11 15 27

and then we keep the underline for textfields everywhere?
I like the input box better, but I see the point to keep it simple and then we don't need to change it everywhere.

@lozanaross
Copy link

@Grizzly127 - great, this looks very simple and clean - I agree the input box you designed originally looks better, but it's a matter of how easy it would be to change it everywhere in one go. Maybe we can discuss with @ZetOE & @HeyItsBATMAN

@lozanaross
Copy link

Following up on my previous comment, I think we should go ahead with this latest design shown in @Grizzly127's comment above. I think we can leave the input box redesign until next year, since we'll be changing quite a lot in the visual design then in any case. I would put this issue on the priority list, as it connects to the updates in the nav bar. @HeyItsBATMAN

@HeyItsBATMAN HeyItsBATMAN self-assigned this Sep 14, 2023
@HeyItsBATMAN
Copy link
Collaborator

@lozanaross this does not yet address the case for when a user forgets their username (which can happen).

What do you think of removing the username for login altogether, just keeping the combination of mail & password for logging in?

This would involve some cleanup on the server, which is good in my opinion, and would get rid of the current "forgot username" and "forgot password" situation.

The other option would be to allow logging in using either username or mail, but this would involve a bunch of "is the user logging in with username or with mail"-detection and handling. This is possible, but more likely to introduce bugs.

The suggested design of @Grizzly127 would, other than swapping username with mail, stay the same.

@lozanaross
Copy link

@HeyItsBATMAN
Thanks for continuing the work here.

From user perspective this would be best:

"The other option would be to allow logging in using either username or mail, but this would involve a bunch of "is the user logging in with username or with mail"-detection and handling. This is possible, but more likely to introduce bugs."

But if the risk of bugs is quite high, perhaps we can indeed stick to email only for now. Happy to go ahead with this and keep the design from @Grizzly127 and just using "Enter your email" instead of "username" as you suggest.

cc @luguenth @ZetOE

@luguenth
Copy link
Collaborator

Would totally agree on just using mail for logging in, as we also fixed some problems with that, mail is just more simple. Nice Design work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants