You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running on Windows with MSVC, I am getting memory leak reports because of Algorithm::destroy not not freeing push and specialization constants. The comment says that they are supposed to be freed by the command buffer destructor, but I am not sure this is the case. When freeing them explicitly here like in the commented code, I don't get memory leaks from using constants anymore.
The text was updated successfully, but these errors were encountered:
@axsaucedo Any example that uses push or specialization constants leaks memory. Freeing these explicitly in Algorithm::destroy() fixes this issue (see Archie3d@5a564a1)
The commented code says that "vk::CommandBuffer frees the data", but this is not the case. vkCmdPushConstants does not mention anything about retaining the data pointer, and actually I don't think Vulkan ever retains any data pointer passed to it (please see this comment).
Running on Windows with MSVC, I am getting memory leak reports because of
Algorithm::destroy
not not freeing push and specialization constants. The comment says that they are supposed to be freed by the command buffer destructor, but I am not sure this is the case. When freeing them explicitly here like in the commented code, I don't get memory leaks from using constants anymore.The text was updated successfully, but these errors were encountered: