Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defaulting to use grype cdn and skip cache by default #152

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Defaulting to use grype cdn and skip cache by default #152

merged 2 commits into from
Sep 3, 2024

Conversation

saisatishkarra
Copy link
Collaborator

@saisatishkarra saisatishkarra commented Sep 3, 2024 •
edited
Loading

only use cache during cdn failures and set explicitly

Cause

Targets:

Uses option 1 to skip cache and default to CDN until the issue is fixed and grype CDN is flaky again

@saisatishkarra saisatishkarra requested a review from a team as a code owner September 3, 2024 18:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 3, 2024 •
edited
Loading

Luacheck Report

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
4 tests ±0  4 ✅ ±0  0 💤 ±0  0 ❌ ±0 
8 runs  ±0  8 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7daaca0. ± Comparison against base commit a1f9449.

♻️ This comment has been updated with latest results.

@saisatishkarra
Defaulting to use grype cdn and skip cache by default
6a531ce 
only use cache during cdn failures and set explicitly
@saisatishkarra saisatishkarra force-pushed the chore/disable-grype-cache-default branch from ca4a8b8 to 6a531ce Compare September 3, 2024 18:23
pankajmouriyakong
pankajmouriyakong approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@pankajmouriyakong pankajmouriyakong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

security-actions/scan-docker-image/action.yml Show resolved Hide resolved
@saisatishkarra saisatishkarra merged commit d4d6b2a into main Sep 3, 2024
12 checks passed
@saisatishkarra saisatishkarra deleted the chore/disable-grype-cache-default branch September 3, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankajmouriyakong pankajmouriyakong pankajmouriyakong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saisatishkarra @pankajmouriyakong