Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: limit cleanup to versions created in last X days [KHCP-7885] #58

Merged
merged 8 commits into from
Aug 16, 2023
Merged

feat: limit cleanup to versions created in last X days [KHCP-7885] #58

merged 8 commits into from
Aug 16, 2023

Conversation

ValeryG
Copy link
Collaborator

@ValeryG ValeryG commented Aug 16, 2023 •
edited
Loading

limit the attempt of cleanup to the versions changes in X number of days.

This is to not to go back to the beginning of times and look at every PR preview version.

@github-actions
Copy link

github-actions bot commented Aug 16, 2023 •
edited
Loading

Luacheck Report

1 files  ±0  1 suites  ±0   0s ⏱️ ±0s
4 tests ±0  4 ✔️ ±0  0 💤 ±0  0 ❌ ±0 
8 runs  ±0  8 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5216acf. ± Comparison against base commit 2804623.

♻️ This comment has been updated with latest results.

@ValeryG ValeryG marked this pull request as ready for review August 16, 2023 20:55
@ValeryG ValeryG requested a review from mptap August 16, 2023 20:55
mptap
mptap approved these changes Aug 16, 2023
View reviewed changes
Copy link

@mptap mptap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ValeryG ValeryG merged commit 3c05dce into main Aug 16, 2023
8 checks passed
@ValeryG ValeryG deleted the feat/KHCP-7885_cleanup-timeframe branch August 16, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mptap mptap mptap approved these changes

@adamdehaven adamdehaven adamdehaven approved these changes

@Drew-Kimberly Drew-Kimberly Awaiting requested review from Drew-Kimberly Drew-Kimberly is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ValeryG @adamdehaven @mptap