-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new C api functions ModPlug_GetVersion and ModPlug_Tell #47
Open
sezero
wants to merge
3
commits into
Konstanty:master
Choose a base branch
from
sezero:newapis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We would use this functionality in SDL_mixer. Any plans for merging? |
Can we get this in please so that SDL_mixer and others can use it? |
sezero
force-pushed
the
newapis
branch
3 times, most recently
from
January 28, 2022 08:28
0434fde
to
740266a
Compare
Rebased to current master. |
the function was originally authored and is provided by Vitaly Novichkov. increase the version number to 0.8.10 so the new functions can be checked easily at compile time.
Rebased (again.) |
Is there any chance that this gets in ? |
PING? |
I'll add my ping too. |
PING? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function was originally authored and is provided by Vitaly Novichkov.
Increase the version number to 0.8.10 so the new functions can be checked
easily at compile time.