Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display day and night on the objects visibility graph (PDF) #1

Open
AmauryCarrade opened this issue Jan 30, 2022 · 1 comment
Open
Labels
enhancement New feature or request nice to have
Milestone

Comments

@AmauryCarrade
Copy link

Is your feature request related to a problem? Please describe.
The objects visibility graph, on the PDF version, is great to get an overview of what will be visible on a given date, but it lakes the information on if the object will actually be visible (i.e., when is the night).

Describe the solution you'd like
I suggest to add the sunrise and sunset hours on the graph. One would have to compute these hours for the given date and given location. We could display these dates on the graph using some icon, or maybe a change in color, like so:

Object visibility graph, where the daytime is displayed in blue and the night-time in violet, with a small gradient between them.

If such a solution is used, one must check if the color is visible enough on a black-and-white print, and is contrasted enough to remain accessible (even on paper, it's important!).

Describe alternatives you've considered
N/A

Additional context
N/A


Thanks for this project!

@Deuchnord
Copy link
Member

Thanks for the suggestion, as we discussed yesterday, we might rethink about the way the Sun rise/set is displayed in the graph too.

Yet, this will need the implementation of Kosmorro/lib#46.

@Deuchnord Deuchnord transferred this issue from Kosmorro/kosmorro Jan 31, 2022
@Deuchnord Deuchnord added enhancement New feature or request nice to have labels Jan 31, 2022
@Deuchnord Deuchnord added this to the v1.1 milestone Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have
Projects
None yet
Development

No branches or pull requests

2 participants