Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to the way progress is tracked/shown #1105

Open
1 task done
Prutosaurus opened this issue Sep 23, 2024 · 7 comments
Open
1 task done

Changes to the way progress is tracked/shown #1105

Prutosaurus opened this issue Sep 23, 2024 · 7 comments

Comments

@Prutosaurus
Copy link

Describe your suggested feature

So ever since I started using the App it had problems showing th progress accurately, so I'd like to ask the devs to change the way it's calculated if possible(I'm not good at the programming side, but believe the weird progress tracking is due to the formulas used to calculate it), or if not possible add a function to show chapters read out of available chapters instead of the checkmark, (i.e show (12/3456) in the corner) I really hope for something like this to be added since it becomes hard to keep track of what you've and what not when it ignores 5 unread chapter with larger mangas and show them as completed, thanks.

Acknowledgements

  • This is not a duplicate of an existing issue. Please look through the list of open issues before creating a new one.
@MariusAlbrecht
Copy link
Contributor

Please provide specific steps to reproduce. It's not clear imo what your issue is.

@Prutosaurus
Copy link
Author

Hi what I want fixed would be this
Screenshot_2024-10-14-16-37-16-418_org koitharu kotatsu
Screenshot_2024-10-14-16-37-21-659_org koitharu kotatsu-edit
As you can see in the picture there clearly are more chapters to read, but in the browser it's marked completed.
As I said it's not the worst, but it gets annoying when you have a lot of titles saved

@MariusAlbrecht
Copy link
Contributor

MariusAlbrecht commented Oct 14, 2024

I understand now. It seems like the app considers anything above 99.5% progress as completed.

https://github.com/KotatsuApp/Kotatsu/blob/devel/app%2Fsrc%2Fmain%2Fkotlin%2Forg%2Fkoitharu%2Fkotatsu%2Flist%2Fdomain%2FReadingProgress.kt#L41
const val PROGRESS_COMPLETED = 0.995f

Imo that should be 100%.
Does the app only showing the checkmark on 100% progress (showing 99% otherwise) align with your expectations?

@Prutosaurus
Copy link
Author

Yes, that would be awesome, thank you for all the work

MariusAlbrecht added a commit to MariusAlbrecht/Kotatsu that referenced this issue Oct 15, 2024
Up until now a progress of >= 99.5% would count a Manga as completed (and show the checkmark icon). This causes manga with 200 chapters or more to be marked as completed even if they have at least one unread chapter.

KotatsuApp#1105
Koitharu pushed a commit that referenced this issue Oct 21, 2024
Up until now a progress of >= 99.5% would count a Manga as completed (and show the checkmark icon). This causes manga with 200 chapters or more to be marked as completed even if they have at least one unread chapter.

#1105
Koitharu pushed a commit that referenced this issue Oct 23, 2024
Up until now a progress of >= 99.5% would count a Manga as completed (and show the checkmark icon). This causes manga with 200 chapters or more to be marked as completed even if they have at least one unread chapter.

#1105
(cherry picked from commit b6f57e5)
@MariusAlbrecht
Copy link
Contributor

@Prutosaurus the relevant change should be in the new update

@3M44D
Copy link

3M44D commented Nov 5, 2024

This is issue also persists when you download the last chapter and read it online, it shows as 1 of 1 chapter on the device page and then the percent drops to 1% of the downloaded chapter

The problem is that it also updates the history page and favourites page that I'm at 1% and then proceeds to continue or mark my last read to the 1st chapter

Thus, No sync between downloaded and online mangas/manhwas chapter progress.
Also, can't be solved if I set the progress as chapters read or anything else.

And some mangas also dont show progress on the thumbnail even if started reading.

Thank You

@MariusAlbrecht
Copy link
Contributor

I don't think that's the same issue. However I can partially reproduce the behaviour described by you and have opened up a new separate issue for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants