Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Link share of guest view fails silently. #861

Open
BrookeDot opened this issue Nov 10, 2024 · 4 comments
Open

V2: Link share of guest view fails silently. #861

BrookeDot opened this issue Nov 10, 2024 · 4 comments
Labels
awaiting Response Issue is awaiting response for a long time already. Bug Something isn't working

Comments

@BrookeDot
Copy link

Bug Description

The share icon is shown in guest mode but clicking the icon does not return the share drop down that appears when logged in. I checked and didn't have any JavaScript errors.

How to reproduce

  1. Start on a public list, ie https://example.com/guest/links?link-display=1
  2. Click the "Share Icon"
  3. Nothing happens.

Expected behavior

Ideally I think that disabling sharing in guest view could be a nice feature to have an option for, but at the very least to resolve the bug the share icons should be returned.

Logs

No response

Screenshots

Guest

linkace_share-2024-11-09_21.35.19.mp4

Logged In

linkace_share_logged_in-2024-11-09_21.37.50.mp4

LinkAce version

v2.0-Beta4

Setup Method

PHP

Operating System

Linux (Ubuntu, CentOS,...)

Client details

Debian 12, Firefox Deb.

@BrookeDot BrookeDot added the Bug Something isn't working label Nov 10, 2024
@Kovah
Copy link
Owner

Kovah commented Nov 10, 2024

Thanks for the detailed report! Will have a look before the release.

@Kovah
Copy link
Owner

Kovah commented Nov 17, 2024

Hi @BrookeDot. Testing this locally and with the v2 demo, sharing is working as expected.

It could be possible that there's something with your general setup. In your second screenshot, the placement of Storyville Coffee looks weird. Did you download the installation package from Github?

@Kovah Kovah added the awaiting Response Issue is awaiting response for a long time already. label Nov 17, 2024
@BrookeDot
Copy link
Author

Did you download the installation package from Github?

Yes, running Beta 4 from the GitHub so possible this was fixed after that was released, or like you said, something is off in my local install. Thanks for looking!

I can try to build and install locally if that would help, but think we can likely close this out as the demo is working.

@Kovah
Copy link
Owner

Kovah commented Nov 21, 2024

Will have another look at the install package, maybe something's wrong with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting Response Issue is awaiting response for a long time already. Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants