Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GeoMechanicsApplication] Remove redundant parameter NUMBER_OF_UMAT_PARAMETERS #12885

Closed
WPK4FEM opened this issue Nov 28, 2024 · 0 comments · Fixed by #12900
Closed

[GeoMechanicsApplication] Remove redundant parameter NUMBER_OF_UMAT_PARAMETERS #12885

WPK4FEM opened this issue Nov 28, 2024 · 0 comments · Fixed by #12900
Assignees
@WPK4FEM
Labels
GeoMechanics Issues related to the GeoMechanicsApplication

Comments

@WPK4FEM
Copy link
Contributor

WPK4FEM commented Nov 28, 2024

Should be replaced by looking at the actual given length of UMAT_PARAMETERS.
This extra item introduces yet another way to give inconsistent input.

created in geo_mechanics_application_variables
registered geo_mechanics_application
used in apply_c_phi_reduction_process, apply_k0_procedure_process
appears in tests for the 2 processes above.

Acceptance Criteria
Given a user runs a computation with UMAT or UDSM material
When the user does not specify NUMBER_OF_UMAT_PARAMETERS
Then the computation gives same errors or results as before
@WPK4FEM WPK4FEM converted this from a draft issue Nov 28, 2024
@WPK4FEM WPK4FEM self-assigned this Nov 28, 2024
@WPK4FEM WPK4FEM added the GeoMechanics Issues related to the GeoMechanicsApplication label Nov 28, 2024
@WPK4FEM WPK4FEM moved this from 📑 Product Backlog to 📋 Sprint Backlog in Kratos Product Backlog Nov 28, 2024
@WPK4FEM WPK4FEM moved this from 📋 Sprint Backlog to 👷 In Progress in Kratos Product Backlog Nov 28, 2024
@WPK4FEM WPK4FEM linked a pull request Nov 29, 2024 that will close this issue
Geo/remove number of umat parameters #12892
Closed
@WPK4FEM WPK4FEM removed a link to a pull request Nov 29, 2024
Geo/remove number of umat parameters #12892
Closed
@WPK4FEM WPK4FEM linked a pull request Nov 29, 2024 that will close this issue
Geo/remove number of umat parameters #12892
Closed
@WPK4FEM WPK4FEM moved this from 👷 In Progress to 👀 In Review in Kratos Product Backlog Nov 29, 2024
@WPK4FEM WPK4FEM removed a link to a pull request Dec 4, 2024
Geo/remove number of umat parameters #12892
Closed
@WPK4FEM WPK4FEM linked a pull request Dec 4, 2024 that will close this issue
Geo/delete number of umat parameters #12900
Merged
@github-project-automation github-project-automation bot moved this from 👀 In Review to ✅ Done in Kratos Product Backlog Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@WPK4FEM WPK4FEM

Labels
GeoMechanics Issues related to the GeoMechanicsApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Geo/delete number of umat parameters KratosMultiphysics/Kratos
1 participant
@WPK4FEM