[Core] Adding SynchronizePointsWithBoundingBox method
#11877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
added
Enhancement
Kratos Core
Parallel-MPI
|
@roigcarlo can you take a look? |
roigcarlo
reviewed
Dec 20, 2023
kratos/utilities/search_utilities.h
Outdated
|
|
||
| // Auxiliary variables | ||
| std::size_t counter = 0; | ||
| array_1d<double, 3> coordinates; |
There was a problem hiding this comment.
Just a suggestion, I found the declaration of coordinates here confusing, because then you are forced to use noalias(coordinates) to avoid the copy. In this particular case, and since the only usage is to assign it, you could just
send_points_coordinates[3 * counter + i_coord] = it_point->Coordinates()[i_coord]or
auto & coords = it_point->Coordinates();
send_points_coordinates[3 * counter + i_coord] = coords[i_coord]But both of them would get optimized anyway....
kratos/utilities/search_utilities.h
Outdated
|
|
||
| // Some definitions | ||
| IndexType i_coord = 0; | ||
| array_1d<double, 3> coordinates; |
There was a problem hiding this comment.
Similar comment, but in this function you are only using it in the serial condition so even better.
Co-authored-by: Carlos Roig <[email protected]>
Co-authored-by: Carlos Roig <[email protected]>
Co-authored-by: Carlos Roig <[email protected]>
|
Shold be Okay now @roigcarlo |
roigcarlo
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
This method will be used in the future
SearchWrapperclass in order to estimate the points to be computed in the distributed search taking into account a bounding box filtering (only the points insise the BB).🆕 Changelog