-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[External] Adding Google benchmark option in CMake #12867
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From my side, 👍
Thx for the clean implementation.
Could you add a kratos_add_benchmarks
call into the core to compile the example maybe? or you plan to do it in another PR¿
I don't get you |
You add an example but its not compiling, or I am missing something? |
Nope, because default is disabled. Can be activated to CI if you like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well to be honest it does not matter in the CI, ok
📝 Description
Related #12861
This PR adds (as external download like in GTest) Google benchmark, see https://github.com/google/benchmark. It will generate one binary per file automatically detected in the
benchmark
folder. The executable will be in the binarybenchmark
folder.It is activated with
KRATOS_BUILD_BENCHMARK
, which is disabled by default.Here an example of usage:
It also includes a python script in order to compare the results (exported as json), example:
🆕 Changelog