Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Rerquest]: When setting AllowFormChrome = false, then the Form Bar should still be Theme rendered #124

Closed
Smurf-IV opened this issue May 31, 2021 · 4 comments
Closed

[Feature Rerquest]: When setting AllowFormChrome = false, then the Form Bar should still be Theme rendered #124

Smurf-IV opened this issue May 31, 2021 · 4 comments
Labels
completed This issue has been completed. enhancement New feature or request
Milestone
Version 95

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented May 31, 2021 •
edited
Loading

Describe the bug
As per discussion in #114.

Expected behavior
When setting AllowFormChrome = false then the Form Title bar should still follow Krypton themeing

Screenshots
image
@Smurf-IV Smurf-IV added the bug Something isn't working label May 31, 2021
@Smurf-IV Smurf-IV added the area:themes All things to do with themes. label Jun 11, 2021
@Smurf-IV Smurf-IV changed the title [Bug]: When setting AllowFormChrome = false, then the Form Bar should still be Theme rendered [Feature Rerquest]: When setting AllowFormChrome = false, then the Form Bar should still be Theme rendered Feb 13, 2022
@Smurf-IV Smurf-IV added enhancement New feature or request and removed bug Something isn't working labels Feb 13, 2022
@Smurf-IV Smurf-IV self-assigned this Dec 17, 2023
Smurf-IV added a commit that referenced this issue Dec 24, 2023
@Smurf-IV
- Whilst investigating #124 : fix some designer issues
ceda57c
@Smurf-IV Smurf-IV added the in progress A fix for this issue is in the works. label Dec 24, 2023
@Smurf-IV Smurf-IV added this to the Version 90 milestone Dec 24, 2023
@Smurf-IV
Copy link
Member Author

  • AllowFormChrome has been removed and replaced with UseThemeFormChromeBorderWidth to better explain what it is doing
  • It means that a theme can get closer to "Material Design", and that the Title bar can still be themed (And rounded)

image

Things of note in the above image:

  • "Form1" is the normal Blue themed bar and border
  • "Form7" is the child form with:
    • UseThemeFormChromeBorderWidth set false
    • Form Rounding = 10
    • Still resizeable
    • Still "Clips" correctly at the corners (See the right button clipping)

PWagner1 added a commit that referenced this issue Dec 24, 2023
@PWagner1
Merge pull request #1246 from Krypton-Suite/alpha-124-AllowFormChrome
2f7ee8e 
- Whilst investigating #124 : fix some designer issues
@PWagner1
Copy link
Contributor

AllowFormChrome has been removed and replaced with UseThemeFormChromeBorderWidth to better explain what it is doing

Should this be mentioned as a "breaking change"?

@Smurf-IV
Copy link
Member Author

AllowFormChrome has been removed and replaced with UseThemeFormChromeBorderWidth to better explain what it is doing

Should this be mentioned as a "breaking change"?

Yes. It will be in the PR that performs the fixes above.
Got to go and check that it does not break ribbon etc ;-(

@Smurf-IV
Copy link
Member Author

  • AllowFormChrome has been removed and replaced with UseThemeFormChromeBorderWidth to better explain what it is doing
  • It means that a theme can get closer to "Material Design", and that the Title bar can still be themed (And rounded)

image

Things of note in the above image:

  • "Form1" is the normal Blue themed bar and border
  • "Form7" is the child form with:
    • UseThemeFormChromeBorderWidth set false
    • Form Rounding = 10
    • Still resizeable
    • Still "Clips" correctly at the corners (See the right button clipping)

An Example of the value change @ runtime:
example

Smurf-IV added a commit that referenced this issue Dec 24, 2023
@Smurf-IV
- Remove AllowFormChrome and replace with a sensible named Value fr…
48a23be 
…om `Current Metrics`

- Fix fallout from changes
- A few nullables
- KryptonManager designer `IsDefault` visibility fix
- Update "Breaking Changes"

#139
#124
@Smurf-IV Smurf-IV mentioned this issue Dec 24, 2023
Merged
@Smurf-IV Smurf-IV removed their assignment Dec 24, 2023
@Smurf-IV Smurf-IV added completed This issue has been completed. and removed area:themes All things to do with themes. in progress A fix for this issue is in the works. labels Dec 24, 2023
Smurf-IV added a commit to Krypton-Suite/Standard-Toolkit-Demos that referenced this issue Dec 24, 2023
@Smurf-IV
- Fix fallout from the following
781d84b 
Krypton-Suite/Standard-Toolkit#139
Krypton-Suite/Standard-Toolkit#124
@Smurf-IV Smurf-IV mentioned this issue Dec 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
completed This issue has been completed. enhancement New feature or request
Projects
None yet
Milestone
Version 95
Development

When branches are created from issues, their pull requests are automatically linked.

alpha-124-AllowFormChrome Krypton-Suite/Standard-Toolkit
2 participants
@PWagner1 @Smurf-IV