-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request]: Implementation of MessageDialog
#1376
Comments
@Smurf-IV I think this might be what we need https://github.com/JohannBlais/InformationBox/tree/master |
@Wagnerp & @Smurf-IV & @tobitege Maybe another solution to this MessageDialog. The original KMessageBox is factually only a static wrapper for KryptonMessageBoxForm class. Which is the underlying component that displays the KMB. A copy of KryptonMessageBoxForm could be the start for this dialog approach. Then wrap it in an instantiable class and expose the properties like suggested earlier. Factually KryptonMessageBoxForm already does all the basic stuff needed, is already Kryptonized and from there can be extended with other options. |
@Wagnerp @tobitege @giduac
Actions for v100
thoughts ? |
@Wagnerp @tobitege @Smurf-IV Actions for v90
This dialog can become a handy control for all kinds of tasks. Ideas to add to the list:
|
I appreciate the points you laid out, Smurf, and also concur with @giduac above. Having 2 distinct components - even though causing breaking changes - looks easier to maintain in the mid- to long-term for both the maintainers and the users. Having methods to encapsule above "types" as "ease of use" drop-ins, I guess, could help many users. A roadmap, as @giduac mentions, certainly would provide transparency and helps managing expectations for the reasons given. |
Agreed, I think I will Perform Step 1, BUT Keep the existing KMB and rename it as KMB
And then mention that in the "Breaking Changes" |
KMDialog can then start as a separate entity in Ext kit first (to get all the controls etc sorted And RTL), Then can be moved into Suite once done. |
- Fix Layout of Single line of MessageBox Text - Fix usage of MessageBox Icons when System type selected - Fix detection of Windows Version(s) - Apply Brackets style #1376
Please assign to me. |
@giduac Done |
I think the "Not completed Actions" should be scheduled for V100 |
Yes please tag it V100 |
I think we need to have a good look the already existing |
Taken from #1148 by @giduac
If I seen it correct then there's also an effort to incorporate a timer next to the checkbox. It might be a tall order to get all that working without creating breaking changes.
How about a sort of MessageDialog like in UWP that can be instantiated, configured and then shown.
Also the DialogResult enum remains intact and prevents confusion about all the additional values in there since DialogResult is not only used by KMessageBox
For example:
In that instantiated dialog you can embed all kinds of nifty stuff like timers / hyperlinks / scrollable text / etc. and as soon as the user closes it you can examine the dialog properties for the choices the user made.
The text was updated successfully, but these errors were encountered: