Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Trying to add a "KTheme" Combo or List box to a form causes a "Universe not found exception #1583

Closed
Smurf-IV opened this issue Jun 29, 2024 · 7 comments
Labels
area:designer All issues related to the designer. area:toolkit All issues related to the toolkit components. bug Something isn't working fixed This issue has been fixed. in progress A fix for this issue is in the works. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90. visual studio All issues related to Visual Studio.

Comments

@Smurf-IV
Copy link
Member

Smurf-IV commented Jun 29, 2024

Using today's alpha branches from both repo's.

Open Designer for "KryptonListBox Example"
Drag a KComboBox onto form - Ok it does it
Drag a Themed KCombo or KListBox and there is a universe cannot be resolved error:
Win 10 22H2 latest

Using VS 17.11 p2.1
ThemedBox

In VS 17.10.3 (and 17.9.6) then you also get an extra box thrown over the universe box:
image

@Smurf-IV Smurf-IV added bug Something isn't working regression Something was working in a previous release, but isn't working now. area:designer All issues related to the designer. visual studio All issues related to Visual Studio. area:toolkit All issues related to the toolkit components. labels Jun 29, 2024
@giduac
Copy link
Contributor

giduac commented Jul 9, 2024

Hi @Smurf-IV,

It's also with other controls, but not all.

The message can be removed by adding an "Assembly reference" to the project for System.Design.

@Smurf-IV
Copy link
Member Author

It's also with other controls, but not all.

Hence the reason for this bug. Adding a designer to the Dev projects that uses Krypton should not be the solution.

@giduac
Copy link
Contributor

giduac commented Jul 10, 2024

Hi @Smurf-IV,

Ok, got it.

The designers/action lists are up for a review in V100, #1521.

ThemeCombo & ThemeListbox both inherit their designers and action lists from the KCombo & KListbox. These action lists expose properties that are unwanted for these controls. The KryptonStubDesigner exposes no action list and stops it from inheriting one. Only ThemeCBB and ThemeListBox are affected.

I tested a dummy designer that does nothing and derives from ControlDesigner.

    internal class KryptonStubDesigner : ControlDesigner
    {
    }

This removes the "universe" errors. Possibly can be used for other controls as well.

The ThemeCombo header is changed to this (KThemeListbox is similar of course)

    /// <summary>Allows the user to change themes using a <see cref="KryptonComboBox"/>.</summary>
    /// <seealso cref="KryptonComboBox" />
    [Designer(typeof(KryptonStubDesigner))]
    public class KryptonThemeComboBox : KryptonComboBox, IKryptonThemeSelectorBase

I'd like your OK on this before moving on?
And, please assign the ticket me, ty.

@giduac
Copy link
Contributor

giduac commented Jul 13, 2024

Hi @Smurf-IV,

Please have a look at the above and let me know if this is OK ?

@Smurf-IV Smurf-IV added the in progress A fix for this issue is in the works. label Jul 13, 2024
@Smurf-IV
Copy link
Member Author

Assigned, and please "Fix" in the v85 branch as well please ?

@giduac
Copy link
Contributor

giduac commented Jul 13, 2024

Assigned, and please "Fix" in the v85 branch as well please ?

@Smurf-IV
Thanks & I'll check V85 as well.

@giduac
Copy link
Contributor

giduac commented Jul 13, 2024

@Smurf-IV or @Wagnerp
This can be closed then, ty.

@PWagner1 PWagner1 added fixed This issue has been fixed. version:90 All things to do with V90. version:85-lts All things to do with V85 LTS. labels Jul 13, 2024
@PWagner1 PWagner1 added this to the Version 85 milestone Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:designer All issues related to the designer. area:toolkit All issues related to the toolkit components. bug Something isn't working fixed This issue has been fixed. in progress A fix for this issue is in the works. regression Something was working in a previous release, but isn't working now. version:85-lts All things to do with V85 LTS. version:90 All things to do with V90. visual studio All issues related to Visual Studio.
Projects
None yet
Development

No branches or pull requests

3 participants