Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: KButton does not retain the same height when autosizing is applied #1641

Open
PWagner1 opened this issue Jul 17, 2024 · 9 comments
Open

[Feature Request]: KButton does not retain the same height when autosizing is applied #1641

PWagner1 opened this issue Jul 17, 2024 · 9 comments
Labels
area:toolkit All issues related to the toolkit components. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.

Comments

@PWagner1
Copy link
Contributor

After some extensive testing, I have found that the KButton does not retain the same height when autosizing options are applied. This does not occur with a standard WinForms button.
@PWagner1 PWagner1 added bug Something isn't working area:toolkit All issues related to the toolkit components. labels Jul 17, 2024
@Smurf-IV
Copy link
Member

Can you add some images as to why/how you spotted this please ?

@PWagner1
Copy link
Contributor Author

Can you add some images as to why/how you spotted this please ?

@Smurf-IV

Hope this helps, found it when creating dialogs

1641

@Smurf-IV
Copy link
Member

I still do not understand what the problem is; The 2 buttons are using 2 different fonts therefore there sizes will be different, and there default sizes (Start sizes) are different as well ?

@giduac
Copy link
Contributor

giduac commented Oct 14, 2024

@PWagner1

Can this be closed?

@giduac giduac added the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Oct 14, 2024
@PWagner1
Copy link
Contributor Author

@giduac & @Smurf-IV

What I mean is KButton is significantly smaller when auto size properties are applied. The same is not true for a WinForms button

@PWagner1 PWagner1 removed the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Oct 16, 2024
@giduac
Copy link
Contributor

giduac commented Oct 17, 2024 •
edited
Loading

@PWagner1 & @Smurf-IV

Looks like this has to do with flat style. When a Wforms button is assigned a border through flat style and FlatStyle is set to flat the is equal.

Doesn't strike me as a bug...

image

@giduac
Copy link
Contributor

giduac commented Oct 17, 2024

The way you display it makes the KButton 1 pixel larger in height...

@PWagner1
Copy link
Contributor Author

@PWagner1 & @Smurf-IV

Looks like this has to do with flat style. When a Wforms button is assigned a border through flat style and FlatStyle is set to flat the is equal.

Doesn't strike me as a bug...

image

@giduac

Should I turn it into a feature request, as it's really annoying if you're trying to design a dialog?

@giduac
Copy link
Contributor

giduac commented Oct 17, 2024

@PWagner1

Dunno...

@PWagner1 PWagner1 changed the title [Bug]: KButton does not retain the same height when autosizing is applied [Feature Request]: KButton does not retain the same height when autosizing is applied Oct 17, 2024
@PWagner1 PWagner1 added enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested. and removed bug Something isn't working labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:toolkit All issues related to the toolkit components. enhancement New feature or request new feature A new feature has been requested. suggestion A suggestion has been requested.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PWagner1 @Smurf-IV @giduac