[Feature Request]: Implement embedded XML/Json based themes

[giduac]

Is your feature request related to a problem? Please describe.
In V100 implement the current built-in themes as XML based embedded themes.

Describe the solution you'd like
The objective is to make all themes editable in the Palette Designer to remove the need to change theme settings via the source.
The Palette Designer will need to be updated as well.

---

At this point Inventory only (all is subjected to change).

We need a good plan so the outcome will be known and we can control the process throughout.

We should set ourselves the goal to complete this without breaking changes.

---

So far.

General discussion points

• Is it the right moment to combine all those proposed changes to KryptonCustomPaletteBase with this migration? Or is it better to do this before or afterwards?

Current built-in themes

• [Feature Request]: It can be that devs are using custom themes based on the current built-in themes.. That would mean that built-in themes should be retained for at least 1 version. #2059

KryptonCustomPaletteBase

• [Feature Request]: For Json support a library is needed that is supported on all TFMs. If this proves problematic or cumbersome we might better stick with XML. https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/overview #2060
• [Feature Request]: A XML to JSON conversion tool (must not overwrite older XML based palettes) #2061
• [Feature Request]: Ability to set a theme name (will be useful for identifying custom themes) #2062
• [Feature Request]: Conversion from existing V20 to whatever this will be called #2063
• [Feature Request]: Possible use of System.Json (With a switch back to a default implementation for pre core versions) #2064
• [Feature Request]: Proper use of serialization/deserialization when importing/exporting JSON files #2065
  • [Feature Request]: Ensure the capture of complex property types, i.e. KryptonPaletteCommon, KryptonPaletteButtonSpecs etc #2086
• [Feature Request]: Update KryptonCustomPaletteBase action list options to allow for exporting/importing JSON files #2087

Toolkit Embedded theming implementation

• [Feature Request]: Store the built-in themes in a separate resource #2066
• [Feature Request]: If we go for Json, the KryptonCustomPaletteBase will need to have import / export interfaces for this before starting #2067
• [Feature Request]: If needed, add API interfaces that extract and load a theme from the resource. #2068
• [Feature Request]: Theme switching needs to load embedded instead of built-in themes. #2069

Palette Designer

• [Feature Request]: Add Ability to export all built-in themes to XML or Json (part of the KryptonCustomPaletteBase ) #2070
• [Feature Request]: The new PD version should only work with V100 #2071
• [Feature Request]: The older version is retained for compatibility with V80 & V90 #2072
• [Feature Request]: When built-in themes have been exported the support for old style built-in themes can be disabled and later removed. #2073
• [Feature Request]: Import/load Export/save custom themes for editing as XML or Json. #2074
• [Feature Request]: WYSIWYG: Only the demo controls are connected to the palette being edited. The PD system controls have a fixed theme. #2075
• [Feature Request]: WYSIWYG: The active loaded theme should be directly and fully reflected in the demo controls #2076
• [Feature Request]: WYSIWYG: Changes to the active theme (live editing) should be directly visible in the demo controls. #2077

Points made but outside of the migration path (for now)

• [Feature Request]: Use of OO #2078
• [Feature Request]: Not binary (As these things seem to be replaced on each version of .NET) #2079
• [Feature Request]: Upgrade / Versioning that is "NOT" related to the version of the suite! #2080
• [Feature Request]: Better naming of the areas the colours are related to (I.e. palette designer) #2081
• [Feature Request]: Better naming of the enums for individual colours as exported / referenced #2082
• [Feature Request]: Better usages of the Colour Tables (Whatever they are supposed to be ??) #2083
• [Feature Request]: "System theme" is the actual system OS theme and not a default win95 substitute #2084
• [Feature Request]: Images to be stored as icons, and then these are used for the dpi images via a cache and an eventing system to refresh it! #2085

[PWagner1]

I really think that the palletes might have to be re-arcitected, as there are features that are redundant for some but not for others, for example image margins

[PWagner1]

Also, I think it would be a good idea to simplify creation of new palettes.

[PWagner1]

JSON would be a great replacement for XML, as it's simple and easy to read and edit in another code editor such as VS Code.

[PWagner1]

I do have a bulk upgrader ready to go, I wonder if it can be modified to convert XML to JSON?

Edit: Yes, it can but it needs to be done within the app itself, as it requires a specific NuGet package

[Smurf-IV]

Yes, it can but it needs to be done within the app itself, as it requires a specific NuGet package

There is no reason to have a nuget package, when core has System.json built in. Just make the Palette tool be core only !

[PWagner1]

@Smurf-IV & @giduac

We now have a workable conversion tool (.NET only)

[Smurf-IV]

So how will "these" new json files be used in Framework version sof the suite without using an external nuget ?

[PWagner1]

So how will "these" new json files be used in Framework version sof the suite without using an external nuget ?

This is using the native System.Json API

[Smurf-IV]

This is using the native System.Json API

BUT I thought that System.Json that does not exist prior to .net Core.
Or, is there also a a retrofit for that ?

[PWagner1]

This is using the native System.Json API

BUT I thought that System.Json that does not exist prior to .net Core. Or, is there also a a retrofit for that ?

It's only for .NET at the moment. I don't know if it'll be easier to use the existing code to create a temporary XML file, then convert it to JSON?

[giduac]

@PWagner1, @Smurf-IV & @Ahmed-Abdelhameed

Topic start updated with the findings so far.
please re-read and comment here, I will process the outcome.

[giduac]

System.Json

@PWagner1 & @Smurf-IV
I suggest you have read about Json here to see if this will "fit".
https://learn.microsoft.com/en-us/dotnet/standard/serialization/system-text-json/overview

[PWagner1]

@Smurf-IV & @giduac

I'm going to turn each item in the list into individual FR's, so as soon as they're completed, the list updates with check marks

[giduac]

@Smurf-IV & @giduac

I'm going to turn each item in the list into individual FR's, so as soon as they're completed, the list updates with check marks

@PWagner1 & @Smurf-IV

• That's fine, but, please, no sooner as when the list is final (still some discussion open of how to go about things, which will save work in the end).
• Also we can add the FR number to each item so we can easily find it.

[PWagner1]

@Smurf-IV & @giduac
I'm going to turn each item in the list into individual FR's, so as soon as they're completed, the list updates with check marks

@PWagner1 & @Smurf-IV

• That's fine, but, please, no sooner as when the list is final (still some discussion open of how to go about things, which will save work in the end).
• Also we can add the FR number to each item so we can easily find it.

Hi @giduac

Yes, the FR number is added to the list automatically (and hyperlinked)