Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: ImageMarginxxx options do not work as expected in Office 2010/365 palettes #638

Open
PWagner1 opened this issue Feb 9, 2022 · 6 comments
Assignees
Labels
area:themes All things to do with themes. bug Something isn't working under investigation This bug/issue is currently under investigation. version:85-lts All things to do with V85 LTS. version:95 All things to do with V95. version:100 All things to do with V100.

Comments

@PWagner1
Copy link
Contributor

PWagner1 commented Feb 9, 2022

Launch the Palette Designer app select 'Chrome + TMS' option > BasePaletteMode > (Any O2k7 option). Navigate to ToolMenuStatus > Menu > change the colours for ImageMarginxxx options > click a menu strip option > see results. Rinse & repeat for other palette types.

@PWagner1 PWagner1 added bug Something isn't working help wanted Extra attention is needed area:themes All things to do with themes. labels Feb 9, 2022
@Smurf-IV Smurf-IV added version:85-lts All things to do with V85 LTS. and removed help wanted Extra attention is needed labels Jul 7, 2024
@Smurf-IV Smurf-IV added this to the Version 90 milestone Jul 7, 2024
@PWagner1 PWagner1 added the version:90 All things to do with V90. label Sep 21, 2024
@PWagner1 PWagner1 modified the milestones: Version 90, Version 85 Sep 21, 2024
@Smurf-IV Smurf-IV added the awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. label Dec 17, 2024
@Smurf-IV
Copy link
Member

Hmm, In the V85 codebase:
The only "Renderers" that seem to actually use the Gradient stuff properly are the Professional and System
The 2007 base just uses a solid colour across the indicator area
And the others just ignore them !
image

@Smurf-IV
Copy link
Member

@PWagner1 So I assume something like this is required for "ALL" palettes?
image

@Smurf-IV
Copy link
Member

And also these do not appear to work either !
image

@Smurf-IV Smurf-IV added version:100 All things to do with V100. version:95 All things to do with V95. and removed version:90 All things to do with V90. labels Dec 18, 2024
@Smurf-IV
Copy link
Member

The colours are useless for everything apart from the System and professional.
Each palette above them uses fewer and fewer of the options (Hence the confusion!)
I propose to: Implement the colouring as per the base system in ALL themes; thus the designer settings are actually sensible and meaningful!

@Krypton-Suite Krypton-Suite deleted a comment from PWagner1 Dec 29, 2024
@Krypton-Suite Krypton-Suite deleted a comment from PWagner1 Dec 29, 2024
@Krypton-Suite Krypton-Suite deleted a comment from PWagner1 Dec 29, 2024
@Krypton-Suite Krypton-Suite deleted a comment from PWagner1 Dec 29, 2024
@Krypton-Suite Krypton-Suite deleted a comment from PWagner1 Dec 29, 2024
@PWagner1
Copy link
Contributor Author

The colours are useless for everything apart from the System and professional. Each palette above them uses fewer and fewer of the options (Hence the confusion!) I propose to: Implement the colouring as per the base system in ALL themes; thus the designer settings are actually sensible and meaningful!

I think this is pointing to a redesign of the palette system to cut some bloat. Thoughts?

@Smurf-IV
Copy link
Member

I think this is pointing to a redesign of the palette system to cut some bloat. Thoughts?

No bloat, I'll start to add it via OO style (Might have to go into a few base classes; but that's it!)

@Smurf-IV Smurf-IV added under investigation This bug/issue is currently under investigation. and removed awaiting feedback A fix for this issue has been implemented, waiting for feedback on the fix. labels Dec 30, 2024
@Smurf-IV Smurf-IV self-assigned this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:themes All things to do with themes. bug Something isn't working under investigation This bug/issue is currently under investigation. version:85-lts All things to do with V85 LTS. version:95 All things to do with V95. version:100 All things to do with V100.
Projects
None yet
Development

No branches or pull requests

2 participants