Merge pull request #458 from Kuadrant/fix-extra-metrics-handler

fix: extra metrics handler
Kuadrant · Mar 5, 2024 · 991b6eb · 991b6eb
2 parents aa46e55 + 74900ec
commit 991b6eb
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/main.go b/main.go
@@ -416,15 +416,15 @@ func setupTelemetryServices(opts telemetryOptions) {
 }
 
 func setupManager(options ctrl.Options) (ctrl.Manager, error) {
+	if options.Metrics.BindAddress != "0" {
+		options.Metrics.ExtraHandlers = map[string]http.Handler{"/server-metrics": promhttp.Handler()}
+	}
+
 	mgr, err := ctrl.NewManager(ctrl.GetConfigOrDie(), options)
 	if err != nil {
 		return nil, err
 	}
 
-	if options.Metrics.BindAddress != "0" {
-		options.Metrics.ExtraHandlers = map[string]http.Handler{"/server-metrics": promhttp.Handler()}
-	}
-
 	if options.HealthProbeBindAddress != "0" {
 		if err := mgr.AddHealthzCheck("ping", healthz.Ping); err != nil {
 			return nil, err