add few additonal logs

Signed-off-by: craig <[email protected]> rh-pre-commit.version: 2.2.0 rh-pre-commit.check-secrets: ENABLED
Kuadrant · Oct 30, 2024 · 8a96f5f · 8a96f5f
1 parent 56761dc
commit 8a96f5f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/internal/controller/dnshealthcheckprobe_reconciler.go b/internal/controller/dnshealthcheckprobe_reconciler.go
@@ -67,15 +67,16 @@ func (r *DNSProbeReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 	ctx, _ = r.setLoggerValues(ctx, baseLogger, dnsProbe)
 
 	if dnsProbe.DeletionTimestamp != nil && !dnsProbe.DeletionTimestamp.IsZero() {
+		logger.Info("healthcheckprobe deleted cleaning up workers")
+		r.ProbeManager.StopProbeWorker(ctx, dnsProbe)
 		controllerutil.RemoveFinalizer(dnsProbe, DNSHealthCheckFinalizer)
 		if err = r.Update(ctx, dnsProbe); client.IgnoreNotFound(err) != nil {
 			if apierrors.IsConflict(err) {
 				return ctrl.Result{Requeue: true}, nil
 			}
 			return ctrl.Result{}, err
 		}
-		logger.Info("healthcheckprobe deleted cleaning up workers")
-		r.ProbeManager.StopProbeWorker(ctx, dnsProbe)
+
 		return ctrl.Result{}, nil
 	}
 

diff --git a/internal/probes/worker.go b/internal/probes/worker.go
@@ -191,7 +191,7 @@ func (w *Probe) performRequest(ctx context.Context, protocol, host, path, ip str
 	} else if err != nil {
 		return ProbeResult{CheckedAt: metav1.Now(), Healthy: false, Reason: fmt.Sprintf("error: %s, response: %+v", err.Error(), res)}
 	}
-
+	logger.V(1).Info("health: probe execution complete against ", "url", httpReq.URL, "status code", res.StatusCode)
 	if !slice.Contains[int](ExpectedResponses, func(i int) bool { return i == res.StatusCode }) {
 		return ProbeResult{
 			CheckedAt: metav1.Now(),