Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Health Check CRs from DNS Record reconciler #144

Closed
Tracked by #141
philbrookes opened this issue May 30, 2024 · 0 comments · Fixed by #271
Closed
Tracked by #141

Create Health Check CRs from DNS Record reconciler #144

philbrookes opened this issue May 30, 2024 · 0 comments · Fixed by #271
Assignees
@maksymvavilov
Labels
healthchecks size/small
Milestone
Kuadrant v1

Comments

@philbrookes
Copy link
Collaborator

philbrookes commented May 30, 2024 •
edited
Loading

There should be a health check probe CR created for every Leaf Address against the rootHost.

If the listener is a wildcard, we will not create a health check probe CR.

The health check probe should be owned by the DNS Record and block deletion.

The health checks should be deleted when the DNS Record is deleted.

On every reconcile, we should test every expected health check CR exists, and also no out of date CRs exist that are owned by this DNS Record.
@philbrookes philbrookes mentioned this issue May 30, 2024
Closed
19 tasks
@philbrookes philbrookes changed the title Create a Health Check worker (one per HealthCheckProbe CR) Create a Health Check worker May 30, 2024
@philbrookes philbrookes changed the title Create a Health Check worker Create a Health Check CRs from DNS Record reconciler May 30, 2024
@philbrookes philbrookes moved this to Todo in Kuadrant May 31, 2024
@maleck13 maleck13 added this to the Kuadrant v1 milestone May 31, 2024
@philbrookes philbrookes self-assigned this Sep 12, 2024
@philbrookes philbrookes changed the title Create a Health Check CRs from DNS Record reconciler Create Health Check CRs from DNS Record reconciler Oct 3, 2024
maksymvavilov added a commit that referenced this issue Oct 15, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
1704a96 
Signed-off-by: Maskym Vavilov <[email protected]>
@maksymvavilov maksymvavilov linked a pull request Oct 15, 2024 that will close this issue
Create/Delete HealthCheckProbeCR from DNSRecord Reconciler #271
Merged
maksymvavilov added a commit that referenced this issue Oct 16, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
ec73121 
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov added a commit that referenced this issue Oct 16, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
526484f 
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov added a commit that referenced this issue Oct 16, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
1d1cc86 
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov added a commit that referenced this issue Oct 16, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
f53ce44 
Signed-off-by: Maskym Vavilov <[email protected]>
@maksymvavilov maksymvavilov moved this from In Progress to Ready For Review in Kuadrant Oct 16, 2024
@maksymvavilov maksymvavilov moved this from Ready For Review to In Progress in Kuadrant Oct 16, 2024
maksymvavilov added a commit that referenced this issue Oct 18, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
199216c 
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov added a commit that referenced this issue Oct 18, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
5b48831 
Signed-off-by: Maskym Vavilov <[email protected]>
@maksymvavilov maksymvavilov moved this from In Progress to Ready For Review in Kuadrant Oct 18, 2024
maksymvavilov added a commit that referenced this issue Oct 18, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
15d0b49 
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov added a commit that referenced this issue Oct 23, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
e9a9109 
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov added a commit that referenced this issue Oct 24, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
766495a 
Signed-off-by: Maskym Vavilov <[email protected]>
maksymvavilov added a commit that referenced this issue Oct 24, 2024
@maksymvavilov
gh-144 create health probe CR from DNSRecord reconciler
ce39de6 
Signed-off-by: Maskym Vavilov <[email protected]>
maleck13 pushed a commit that referenced this issue Oct 25, 2024
@maksymvavilov @maleck13
gh-144 create health probe CR from DNSRecord reconciler
a9edcd9 
Signed-off-by: Maskym Vavilov <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Oct 25, 2024
@maleck13
Merge pull request #271 from Kuadrant/gh-144
51b99cb 
Create/Delete HealthCheckProbeCR from DNSRecord Reconciler
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksymvavilov maksymvavilov

Labels
healthchecks size/small
Projects
Kuadrant
Status: Done
Milestone
Kuadrant v1
Development

Successfully merging a pull request may close this issue.

Create/Delete HealthCheckProbeCR from DNSRecord Reconciler Kuadrant/dns-operator
3 participants
@maleck13 @philbrookes @maksymvavilov