Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule removal of finalizer from DNS Records #38

Closed
philbrookes opened this issue Mar 1, 2024 · 0 comments · Fixed by #72
Closed

Schedule removal of finalizer from DNS Records #38

philbrookes opened this issue Mar 1, 2024 · 0 comments · Fixed by #72
Assignees
@maksymvavilov
Labels
dnsrecord lifecycle size/small

Comments

@philbrookes
Copy link
Collaborator

philbrookes commented Mar 1, 2024 •
edited
Loading

When a DNS Record is being removed, the following must be successfully completed before the finalizer can be removed:

  • Remove the local clusters records and targets from the relevant zone
  • Requeue
  • Ensure no changes need to be planned

Only once these actions have all resolved should the finalizer be removed, and the DNS Record allowed to be deleted.
This was referenced Mar 1, 2024
Closed
Closed
@philbrookes philbrookes moved this to Todo in Kuadrant Mar 7, 2024
@philbrookes philbrookes changed the title Remove finalizer from DNS Records when deleting Schedule removal of finalizer from DNS Records Mar 7, 2024
@philbrookes philbrookes mentioned this issue Mar 7, 2024
Closed
20 tasks
@maksymvavilov maksymvavilov self-assigned this Apr 8, 2024
@maksymvavilov maksymvavilov moved this from Todo to In Progress in Kuadrant Apr 8, 2024
@maksymvavilov maksymvavilov linked a pull request Apr 10, 2024 that will close this issue
GH-38 validatie record on deletion #72
Merged
@maksymvavilov maksymvavilov mentioned this issue Apr 11, 2024
Merged
@maksymvavilov maksymvavilov moved this from In Progress to Ready For Review in Kuadrant Apr 11, 2024
github-merge-queue bot pushed a commit that referenced this issue Apr 16, 2024
@maleck13
Merge pull request #72 from Kuadrant/GH-38
e333baf 
GH-38 validatie record on deletion
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in Kuadrant Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maksymvavilov maksymvavilov

Labels
dnsrecord lifecycle size/small
Projects
Kuadrant
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-38 validatie record on deletion Kuadrant/dns-operator
3 participants
@mikenairn @philbrookes @maksymvavilov