Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add owner ID to DNS Record spec #59

Merged
merged 1 commit into from
Mar 15, 2024
Merged

add owner ID to DNS Record spec #59

merged 1 commit into from
Mar 15, 2024

Conversation

philbrookes
Copy link
Collaborator

No description provided.

@philbrookes philbrookes requested a review from mikenairn March 15, 2024 10:24
@mikenairn
Copy link
Member

@philbrookes You need to run make bundle and commit the changes

@philbrookes philbrookes force-pushed the gh-492 branch 2 times, most recently from 245847f to 42d4ea6 Compare March 15, 2024 11:06
mikenairn
mikenairn reviewed Mar 15, 2024
View reviewed changes
bundle.Dockerfile Outdated Show resolved Hide resolved
mikenairn
mikenairn approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@mikenairn mikenairn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Obviously we would be looking for tests normally , but since I'm adding some in a PR coming soon and i think we can go with it.

@philbrookes philbrookes merged commit 515b614 into Kuadrant:main Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikenairn mikenairn mikenairn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philbrookes @mikenairn