Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Policy attachment metrics #36

Merged
merged 5 commits into from
Oct 25, 2023
Merged

Policy attachment metrics #36

merged 5 commits into from
Oct 25, 2023

Conversation

Ygnas
Copy link
Collaborator

@Ygnas Ygnas commented Oct 11, 2023 •
edited
Loading

Closes: #4

  • TLSPolicy
  • RateLimitPolicy
  • BackendTLSPolicy
  • Tests

@Ygnas Ygnas force-pushed the policy-attachment-metrics branch 3 times, most recently from 73732e8 to 70503ee Compare October 12, 2023 13:10
@Ygnas Ygnas marked this pull request as ready for review October 12, 2023 13:10
@Ygnas Ygnas requested a review from david-martin October 12, 2023 13:10
@Ygnas Ygnas force-pushed the policy-attachment-metrics branch 9 times, most recently from 6501f22 to c25dad2 Compare October 17, 2023 15:33
@Ygnas Ygnas force-pushed the policy-attachment-metrics branch from c25dad2 to 243ae51 Compare October 17, 2023 15:46
@david-martin
Copy link
Member

Trying out the enterprise example locally, grafana failing to start with this event:

0s          Warning   FailedMount         pod/grafana-767b4bd666-7clvt                MountVolume.SetUp failed for volume "grafana-tlspolicy" : configmap "grafana-tlspolicy" not found

Should it be grafana-policies? The policies.json configmap doesn't seem to be included though

@Ygnas Ygnas force-pushed the policy-attachment-metrics branch from ba684ca to 195aa00 Compare October 20, 2023 08:55
@david-martin
Copy link
Member

Thanks for adding this @Ygnas
This looks like a great start for showing policies in grafana
image

@david-martin david-martin merged commit 22a18c0 into Kuadrant:main Oct 25, 2023
3 checks passed
@guicassolato guicassolato mentioned this pull request Oct 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-martin david-martin david-martin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metrics: Policy Attachment metrics (investigate/proof of concept)
2 participants
@Ygnas @david-martin