Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "cause based" alerts for authorino #672

Open
2 tasks
Tracked by #671
R-Lawton opened this issue May 27, 2024 · 7 comments
Open
2 tasks
Tracked by #671

Add "cause based" alerts for authorino #672

R-Lawton opened this issue May 27, 2024 · 7 comments

Comments

@R-Lawton
Copy link
Contributor

R-Lawton commented May 27, 2024

WHAT
Create cause-based alerts for the authorino

The tabletop scenarios when applicable can be used as inspiration for the alerts

DONE

  • Create alerts for different scenarios for authorino operator
  • Create Promtool unit tests for each new alert
@R-Lawton R-Lawton converted this from a draft issue May 27, 2024
@david-martin david-martin added this to the Kuadrant v1 milestone Jun 4, 2024
@david-martin david-martin changed the title Add "case based" alerts for authorino Add "cause based" alerts for authorino Jul 1, 2024
@david-martin
Copy link
Member

@guicassolato Tagging you on this as an fyi, in case you weren't aware of it.
We created this issue (and similar for other components) to provide some example alerts for the authorino component.
The release was initially set as v1, but since I don't know if this has been prioritised by you or others more familiar with limitador, I set it as v1.2+ instead for now (I can't unset it).

If you need any help on constructing the prometheus queries for what you think are good alerts for limitador, or help on how to construct the alert rules, please do reach out to myself or @R-Lawton .

There are examples of alert rules in here.

@Boomatang
Copy link
Contributor

I want to close this issue. The what and done do not talk about the same thing. It is not clear what is need here.

@R-Lawton
Copy link
Contributor Author

R-Lawton commented Jan 10, 2025

Updated the issue was copy and paste error. The idea is to create cause based alerts for authorino. The table top is in reference to an exercise we did for limitador where a fake issue was created to see whats missing in terms of alerts that could cause inspiration for the cause based alerts. I think its probs a good idea to do a table top scenario with authorino like whats was done in limitador. Ill follow up on that and get back to you

@david-martin
Copy link
Member

@Boomatang this doc puts alerts into 2 category types, one of them being 'cause based' alerts.
These types of alerts are focused on specific known low level problems, like a database connection being down, or a pod frequently crashing.
The opposite are symptom based alerts, that focus on what the impact is on users. For example, getting frequent 503 responses, or high latency.

From an authorino point of view, perhaps there are some scenarios that fall into the first category that would be helpful to have as alerts?
I'd be hesitant to close this issue without first ruling out that it's not relevant to authorino (though I doubt that's the case for any component).
Perhaps there's a phase of investigation required before what is actually delivered is decided on?

@Boomatang
Copy link
Contributor

@david-martin That makes sense. I am questioning is this again the right place for this issue. By what I am hearing, we wont be creating alerts, only creating examples that the user can follow. As this is targeted at authorino is the correct place for this work in the the authorino-operator? I am not seeing the work that the kuadrant-operator needs to do.

@david-martin
Copy link
Member

As this is targeted at authorino is the correct place for this work in the the authorino-operator

That sounds fine to me.
I suspect this issue was created in the kuadrant-operator repo for simplicity of managing the epic and related issues in a single place.
It can be moved there, and linked from the epic.

@R-Lawton
Copy link
Contributor Author

R-Lawton commented Jan 13, 2025

The reason I have it in the kuadrant operator is to be in line with the examples folder that we have that has the current examples. I would be in favour of keeping the alert examples in one location so that if you are a user of kuadrant you can see what types of alerts can be done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

3 participants