authpolicy_controller_test.go test reads resources that it does not watch.

[chirino]

I updated a fork of the operator to log when a reconcile gets a resource it does not watch and these are the resources that the authpolicy_controller_test.go gets without a watch:

  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-79n5x, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-knkzp, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=/v1, Kind=Service, namespace=test-namespace-knkzp, name=test-placed-gateway-istio
  Get without watch: gvk=/v1, Kind=Service, namespace=test-namespace-hrjhn, name=test-placed-gateway-istio
  Get without watch: gvk=/v1, Kind=Service, namespace=test-namespace-79n5x, name=test-placed-gateway-istio
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-hrjhn, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-79n5x, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-hrjhn, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-79n5x, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-hrjhn, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-knkzp, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-hrjhn, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-79n5x, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=/v1, Kind=Service, namespace=test-namespace-hrjhn, name=test-placed-gateway-istio
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-knkzp, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=/v1, Kind=Service, namespace=test-namespace-hrjhn, name=test-placed-gateway-istio
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-hrjhn, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-hrjhn, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-hrjhn, name=on-test-placed-gateway-using-toystore-route
  Get without watch: gvk=security.istio.io/v1beta1, Kind=AuthorizationPolicy, namespace=test-namespace-hrjhn, name=on-test-placed-gateway-using-toystore-route

[guicassolato]

Fixed as part of the SOTW changes (#952).