Skip to content

Commit

Permalink
Updating metrics service name and removing unnessacry patch for metri…
Browse files Browse the repository at this point in the history
…cs port to make limitador operator more inline with authorino-operator
  • Loading branch information
R-Lawton committed Jul 4, 2024
1 parent e3f28fc commit 808507a
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 16 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ local-env-setup: ## Prepare environment to run the operator with "make run"

## Miscellaneous Custom targets
.PHONY: local-setup
local-setup: export IMG := limitador-operator:dev
local-setup: export IMG := localhost/limitador-operator:dev
local-setup: ## Deploy operator in local kind cluster
$(MAKE) local-env-setup
$(MAKE) docker-build
Expand Down
17 changes: 17 additions & 0 deletions bundle/manifests/limitador-operator-metrics_v1_service.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
apiVersion: v1
kind: Service
metadata:
creationTimestamp: null
labels:
control-plane: controller-manager
name: limitador-operator-metrics
spec:
ports:
- name: metrics
port: 8080
targetPort: metrics
selector:
app: limitador-operator
control-plane: controller-manager
status:
loadBalancer: {}
1 change: 0 additions & 1 deletion config/default/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ patchesStrategicMerge:
# If you want your controller-manager to expose the /metrics
# endpoint w/o any authn/z, please comment the following line.
# - manager_auth_proxy_patch.yaml
- manager_metrics_patch.yaml

# Mount the controller config file for loading manager configurations
# through a ComponentConfig type
Expand Down
13 changes: 0 additions & 13 deletions config/default/manager_metrics_patch.yaml

This file was deleted.

3 changes: 3 additions & 0 deletions config/manager/manager.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ spec:
name: manager
securityContext:
allowPrivilegeEscalation: false
ports:
- name: metrics
containerPort: 8080
livenessProbe:
httpGet:
path: /healthz
Expand Down
2 changes: 1 addition & 1 deletion config/manager/metrics_service.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ kind: Service
metadata:
labels:
control-plane: controller-manager
name: controller-manager-metrics-service
name: metrics
namespace: system
spec:
ports:
Expand Down

0 comments on commit 808507a

Please sign in to comment.