Do not overwrite user added labels from deployment spec.template.labels in order to propagate the labels to the pod

[laurafitzgerald]

Is your feature request related to a problem? Please describe.
Add the ability to propagates labels to Deployment's spec.template, in this case the label we are interested in is "sidecar.istio.io/inject":"true" but this can apply to any label and a similar implementation is in progress in Kuadrant/authorino-operator#236

Describe the solution you'd like
See Kuadrant/authorino-operator#236

This work sits under the Zero-trust configuration parent as that work depends on this change but this implementation should be agnostic to that configuration

[eguzki]

Work being done in authorino-operator Kuadrant/authorino-operator#236

[Boomatang]

The label should be removed if the value isn't present or set to false.

While I agree it should be removed if set to false. If the value is not present, should we be removing labels from the deployments that the user may have put there? It sound like a change that would affect existing user on upgrade. I am aware that the CRD is still v1alpha1, but from the context of kuadrant which depends on limitador this has to be seen a breaking change.

[laurafitzgerald]

The label should be removed if the value isn't present or set to false.

While I agree it should be removed if set to false. If the value is not present, should we be removing labels from the deployments that the user may have put there? It sound like a change that would affect existing user on upgrade. I am aware that the CRD is still v1alpha1, but from the context of kuadrant which depends on limitador this has to be seen a breaking change.

Hi @Boomatang I just update the description there as there was some discussion and a previously agreed approach in authorino-operator which it makes sense to take that approach here as well. I hope that addresses your concern.