Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Describe the role of use_proxy_proto: true in Envoy sample config 👺👺👺 #39

Open
paoloantinori opened this issue May 3, 2021 · 1 comment
Labels
area/doc Improvements or additions to documentation participation/good first issue Good for newcomers size/small target/later

Comments

@paoloantinori
Copy link

Hi there.
In a quest to make Limitador working on OpenShift, I have spent some good hours trying to understand what I was doing wrong in adapting the kubernetes example.

It turned out that the source of the issue was use_proxy_proto: true !!!

I've searched in your repo and I have found a reference to that in the kind setup script: https://github.com/3scale-labs/limitador/blob/ace7dd773300b8ab76d95a528380dd3cf53a531e/limitador-server/script/kind-setup.sh

My suggestion would be to mention it's role explicitly in the docs with the correct setting required.

FWIW, this is the output from curl when the flag is set to true:

curl: (52) Empty reply from server
@davidor
Copy link
Contributor

davidor commented May 6, 2021

The instructions that we have in https://github.com/3scale-labs/limitador/tree/master/limitador-server/kubernetes describe how to deploy on AWS via an ELB. In that case, use_proxy_proto needs to be set to true as specified in the Envoy docs:

use_proxy_proto

(BoolValue) Whether the listener should expect a PROXY protocol V1 header on new connections. If this option is enabled, the listener will assume that that remote address of the connection is the one specified in the header. Some load balancers including the AWS ELB support this option. If the option is absent or set to false, Envoy will use the physical peer address of the connection as the remote address.

That's why it's set to true in the templates, but in the script that uses Kind is set to false.

I agree that this should be documented in the README linked above.

@alexsnaps alexsnaps added area/doc Improvements or additions to documentation participation/good first issue Good for newcomers participation/help needed Extra attention is needed size/small target/later and removed participation/help needed Extra attention is needed labels Aug 24, 2022
@alexsnaps alexsnaps added this to the Limitador Server v1.4.0 milestone Dec 8, 2023
@alexsnaps alexsnaps moved this to Todo in Kuadrant Dec 8, 2023
@alexsnaps alexsnaps removed this from the Limitador Server v2.0.0 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/doc Improvements or additions to documentation participation/good first issue Good for newcomers size/small target/later
Projects
Status: Todo
Status: No status
Development

No branches or pull requests

3 participants