From e2fd5efeb5b0115aa45300070331344330794635 Mon Sep 17 00:00:00 2001 From: craig Date: Mon, 13 Nov 2023 12:48:17 +0000 Subject: [PATCH] reduce flakiness by putting update in eventually --- test/e2e/gateway_single_spoke_test.go | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/test/e2e/gateway_single_spoke_test.go b/test/e2e/gateway_single_spoke_test.go index 4a309181..fb5bdba4 100644 --- a/test/e2e/gateway_single_spoke_test.go +++ b/test/e2e/gateway_single_spoke_test.go @@ -409,13 +409,18 @@ var _ = Describe("Gateway single target cluster", func() { } otherHostname = gatewayapi.Hostname(strings.Join([]string{"other", tconfig.ManagedZone()}, ".")) AddListener("other", otherHostname, gatewayapi.ObjectName(otherHostname), gw) - err = tconfig.HubClient().Update(ctx, gw) - Expect(err).ToNot(HaveOccurred()) + expectedLiseners := 3 Eventually(func(ctx SpecContext) error { + err = tconfig.HubClient().Update(ctx, gw) + if err != nil { + return fmt.Errorf("failed to update gateway and add new listeners: %w", err) + } checkGateway := &gatewayapi.Gateway{} err = tconfig.HubClient().Get(ctx, client.ObjectKey{Name: testID, Namespace: tconfig.HubNamespace()}, checkGateway) - Expect(err).ToNot(HaveOccurred()) + if err != nil { + return fmt.Errorf("failed to get updated gateway after adding listeners: %w", err) + } if len(checkGateway.Spec.Listeners) == expectedLiseners { return nil }